Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(message-menu): remove reply to media restriction to wire up and enable reply to images #2014

Merged
merged 19 commits into from
Jun 17, 2024
Merged

feat(message-menu): remove reply to media restriction to wire up and enable reply to images #2014

merged 19 commits into from
Jun 17, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Jun 15, 2024

What does this do?

  • enables replies for media by updating condition to render reply menu option on message menu

Why are we making this change?

  • to enable replies to media

How do I test this?

  • run tests as usual.
  • run UI > send message with media > hover over and select reply

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?
Screenshot 2024-06-15 at 11 57 27

domw30 added 18 commits June 11, 2024 13:13
@domw30
feat(reply-card): render media if media is present in parent message
88c71cb
@domw30
feat: add media prop to parent message type
ed51323
@domw30
feat: add media url and media name attributes to reply card in messag…
73006ac 
…e input
@domw30
refactor: render media when message is not present
3aaeada
@domw30
refactor: optional message args
ce71b99
@domw30
refactor: add test coverage for optional message
b1d204d
@domw30
refactor: amend test date
a118a88
@domw30
feat: pass media into reply
76e466a
@domw30
refactor(reply-card-spec): improve test coverage and test quality for…
29ed766 
… reply card tests
@domw30
feat(message-input-reply-card): redesign component
543057f
@domw30
feat(messges-parent-message): add and handle media replies and redesi…
8c950a2 
…gn component
@domw30
refactor: remove unused css
436592c
@domw30
feat(messages): handle logic and set min-width for messages that are …
3a20f5c 
…replies
@domw30
feat(parent-message-media): fetch parent messages and combine media /…
3fd959b 
… text (WIP)
@domw30
refactor: wip - use root message id to get parent message media
d0d281d
@domw30
refactor: ensure media data is preserved in the sent message
1f92ebe
@domw30
feat: add prop to map message
2ba2041
@domw30
feat(message-menu): remove reply to media restriction to wire up and …
7c7bc8c 
…enable reply to images
@domw30 domw30 requested a review from a team June 15, 2024 10:57
Base automatically changed from feat/fetch-parent-message-media to main June 17, 2024 10:29
@domw30 domw30 merged commit 4391568 into main Jun 17, 2024
5 checks passed
@domw30 domw30 deleted the feat/enable-replies-to-images-menu-item branch June 17, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@domw30