fix(page-load-saga): ensure restricted route persists and does not switch to login route on load complete

Author: domw30

src/store/page-load/saga.test.ts

@@ -131,44 +131,6 @@ describe('page-load saga', () => {
     expect(history.replace).toHaveBeenCalledWith({ pathname: '/restricted' });
     expect(storeState.pageload.isComplete).toBe(true);
   });
-
-  describe('showAndroidDownload', () => {
-    function subject(path: string, userAgent: string) {
-      const initialState = { pageload: { showAndroidDownload: false } };
-      return expectSaga(saga)
-        .provide([
-          [call(getHistory), new StubHistory(path)],
-          [call(getCurrentUser), false],
-          [call(getNavigator), stubNavigator(userAgent)],
-          [spawn(redirectOnUserLogin), null],
-        ])
-        .withReducer(rootReducer, initialState as any);
-    }
-
-    it('is false if not on a configured page', async () => {
-      const { storeState } = await subject('/', 'Android').run();
-
-      expect(storeState.pageload.showAndroidDownload).toBe(false);
-    });
-
-    it('is false if not an android user agent', async () => {
-      const { storeState } = await subject('/login', 'Chrome').run();
-
-      expect(storeState.pageload.showAndroidDownload).toBe(false);
-    });
-
-    it('is true if the user agent matches and is login page', async () => {
-      const { storeState } = await subject('/login', 'Android').run();
-
-      expect(storeState.pageload.showAndroidDownload).toBe(true);
-    });
-
-    it('is true if the user agent matches and is get-access page', async () => {
-      const { storeState } = await subject('/get-access', 'Android').run();
-
-      expect(storeState.pageload.showAndroidDownload).toBe(true);
-    });
-  });
 });
 
 describe(redirectToEntryPath, () => {

src/store/page-load/saga.ts

@@ -17,6 +17,8 @@ export function* saga() {
 
   if (isMobileDevice) {
     history.replace({ pathname: '/restricted' });
+    yield put(setIsComplete(true));
+    return;
   }
 
   const success = yield call(getCurrentUser);