-
Notifications
You must be signed in to change notification settings - Fork 5
/
Copy pathsaga.test.ts
419 lines (362 loc) · 14.9 KB
/
saga.test.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
import { expectSaga } from '../../test/saga';
import * as matchers from 'redux-saga-test-plan/matchers';
import {
closeErrorDialog,
joinRoom,
performValidateActiveConversation,
validateActiveConversation,
isMemberOfActiveConversation,
setWhenUserJoinedRoom,
waitForChatConnectionCompletion,
} from './saga';
import { markConversationAsRead, openFirstConversation } from '../channels/saga';
import { rootReducer } from '../reducer';
import { StoreBuilder } from '../test/store';
import { User } from '../channels';
import { testSaga } from 'redux-saga-test-plan';
import { clearJoinRoomErrorContent, rawSetActiveConversationId, setIsJoiningConversation } from '.';
import { ERROR_DIALOG_CONTENT, JoinRoomApiErrorCode, translateJoinRoomApiError } from './utils';
import { getRoomIdForAlias, isRoomMember } from '../../lib/chat';
import { joinRoom as apiJoinRoom } from './api';
import { call } from 'redux-saga/effects';
import { getHistory } from '../../lib/browser';
describe(performValidateActiveConversation, () => {
function subject(...args: Parameters<typeof expectSaga>) {
return expectSaga(...args).provide([
[matchers.call.fn(getRoomIdForAlias), 'room-id'],
[matchers.call.fn(joinRoom), undefined],
[matchers.call.fn(openFirstConversation), null],
[
matchers.call.fn(getHistory),
{
location: { pathname: '/conversation/some-id' },
},
],
]);
}
it('clears the join room error content if user is member of conversation', async () => {
const initialState = new StoreBuilder()
.withCurrentUser({ id: 'current-user' })
.withConversationList({ id: 'convo-1', name: 'Conversation 1', otherMembers: [{ userId: 'user-2' } as User] })
.withActiveConversation({ id: 'convo-1' })
.withChat({
joinRoomErrorContent: {
header: 'Access Denied',
body: 'You do not have permission to join this conversation.',
},
});
const { storeState } = await subject(performValidateActiveConversation)
.withReducer(rootReducer, initialState.build())
.put(clearJoinRoomErrorContent())
.run();
expect(storeState.chat.joinRoomErrorContent).toBeNull();
});
it('gets the matrix roomId if the active conversation id is an alias', async () => {
const alias = 'wildebeest:matrix.org';
const conversationId = '!wildebeest:matrix.org';
const initialState = new StoreBuilder().withCurrentUser({ id: 'current-user' }).withConversationList({
id: '!wildebeest:matrix.org',
name: 'Conversation 1',
otherMembers: [{ userId: 'user-2' } as User],
});
const { storeState } = await subject(performValidateActiveConversation, alias)
.withReducer(rootReducer, initialState.build())
.provide([
[matchers.call.fn(getRoomIdForAlias), conversationId],
[matchers.call.fn(markConversationAsRead), undefined],
[
matchers.call.fn(getHistory),
{
location: { pathname: '/conversation/some-id' },
},
],
])
.call(getRoomIdForAlias, '#' + alias)
.not.call(apiJoinRoom, conversationId)
.put(rawSetActiveConversationId(conversationId))
.spawn(markConversationAsRead, conversationId)
.run();
expect(storeState.chat.activeConversationId).toBe(conversationId);
});
it('joins the conversation when an id is provided and the user is not a member', async () => {
const initialState = new StoreBuilder().withCurrentUser({ id: 'current-user' });
await subject(performValidateActiveConversation, '!convo-not-exists')
.withReducer(rootReducer, initialState.build())
.provide([
[matchers.call.fn(isMemberOfActiveConversation), false],
[call(joinRoom, '#convo-not-exists'), undefined],
])
.run();
});
it('joins the conversation when an alias is provided that does not exist', async () => {
const initialState = new StoreBuilder().withCurrentUser({ id: 'current-user' });
await subject(performValidateActiveConversation, 'convo-not-exists')
.withReducer(rootReducer, initialState.build())
.provide([
[matchers.call.fn(getRoomIdForAlias), undefined],
[call(joinRoom, '#convo-not-exists'), undefined],
])
.run();
});
it('joins the conversation when an alias is provided and the user is not a member', async () => {
const alias = 'some-other-convo:matrix.org';
const initialState = new StoreBuilder()
.withCurrentUser({ id: 'current-user' })
.withConversationList({ id: 'convo-1', name: 'Conversation 1', otherMembers: [{ userId: 'user-2' } as User] });
await subject(performValidateActiveConversation, alias)
.withReducer(rootReducer, initialState.build())
.provide([
[call(getRoomIdForAlias, `#${alias}`), '!some-other-convo:matrix.org'],
[call(isMemberOfActiveConversation, '!some-other-convo:matrix.org'), false],
[matchers.call.fn(joinRoom), undefined],
])
.call(joinRoom, '#some-other-convo:matrix.org')
.run();
});
it('opens first conversation when social channel is accessed from messenger app', async () => {
const initialState = new StoreBuilder().withCurrentUser({ id: 'current-user' }).withConversationList({
id: 'social-channel',
name: 'Social Channel',
isSocialChannel: true,
});
await subject(performValidateActiveConversation, 'social-channel')
.withReducer(rootReducer, initialState.build())
.provide([
[matchers.call.fn(getRoomIdForAlias), 'social-channel'],
[
matchers.call.fn(getHistory),
{
location: { pathname: '/conversation/social-channel' },
},
],
])
.call(openFirstConversation)
.run();
});
it('does not redirect social channel when accessed from feed app', async () => {
const initialState = new StoreBuilder().withCurrentUser({ id: 'current-user' }).withConversationList({
id: 'social-channel',
name: 'Social Channel',
isSocialChannel: true,
});
await subject(performValidateActiveConversation, 'social-channel')
.withReducer(rootReducer, initialState.build())
.provide([
[matchers.call.fn(getRoomIdForAlias), 'social-channel'],
[
matchers.call.fn(getHistory),
{
location: { pathname: '/feed/social-channel' },
},
],
[matchers.call.fn(markConversationAsRead), undefined],
])
.put(rawSetActiveConversationId('social-channel'))
.spawn(markConversationAsRead, 'social-channel')
.not.call(openFirstConversation)
.run();
});
it('sets active conversation ID if URL path has not changed during validation', async () => {
const initialState = new StoreBuilder()
.withCurrentUser({ id: 'current-user' })
.withConversationList({ id: 'convo-1', name: 'Conversation 1', otherMembers: [{ userId: 'user-2' } as User] });
const history = {
location: { pathname: '/conversation/convo-1' },
};
await subject(performValidateActiveConversation, 'convo-1')
.withReducer(rootReducer, initialState.build())
.provide([
[matchers.call.fn(isMemberOfActiveConversation), true],
[matchers.call.fn(markConversationAsRead), undefined],
[matchers.call.fn(getRoomIdForAlias), 'convo-1'],
[matchers.call.fn(getHistory), history],
])
.put(rawSetActiveConversationId('convo-1'))
.spawn(markConversationAsRead, 'convo-1')
.run();
});
it('does not set active conversation ID or mark conversation as read if URL path has changed during validation', async () => {
const initialState = new StoreBuilder()
.withCurrentUser({ id: 'current-user' })
.withConversationList({ id: 'convo-1', name: 'Conversation 1', otherMembers: [{ userId: 'user-2' } as User] });
const originalHistory = {
location: { pathname: '/conversation/convo-1' },
};
const changedHistory = {
location: { pathname: '/conversation/convo-2' },
};
let historyCallCount = 0;
await expectSaga(performValidateActiveConversation, 'convo-1')
.withReducer(rootReducer, initialState.build())
.provide([
[matchers.call.fn(isMemberOfActiveConversation), true],
[matchers.call.fn(markConversationAsRead), undefined],
[matchers.call.fn(getRoomIdForAlias), 'convo-1'],
{
call(effect, next) {
if (effect.fn === getHistory) {
historyCallCount++;
return historyCallCount === 1 ? originalHistory : changedHistory;
}
return next();
},
},
])
.not.put(rawSetActiveConversationId('convo-1'))
.not.spawn(markConversationAsRead, 'convo-1')
.run();
});
});
describe(isMemberOfActiveConversation, () => {
it('returns true if conversation is in state', async () => {
const initialState = new StoreBuilder().withConversationList({ id: 'convo-1' });
const { returnValue } = await expectSaga(isMemberOfActiveConversation, 'convo-1')
.withReducer(rootReducer, initialState.build())
.run();
expect(returnValue).toBe(true);
});
it('returns true if conversation is not in state but the chat client returns true', async () => {
const initialState = new StoreBuilder().withCurrentUser({ id: 'user-id' }).withConversationList({ id: 'convo-1' });
const { returnValue } = await expectSaga(isMemberOfActiveConversation, 'not-in-state')
.provide([[call(isRoomMember, 'user-id', 'not-in-state'), true]])
.withReducer(rootReducer, initialState.build())
.run();
expect(returnValue).toBe(true);
});
it('returns false if conversation is not in state and chat client returns false', async () => {
const initialState = new StoreBuilder().withCurrentUser({ id: 'user-id' }).withConversationList({ id: 'convo-1' });
const { returnValue } = await expectSaga(isMemberOfActiveConversation, 'not-a-member')
.provide([[call(isRoomMember, 'user-id', 'not-a-member'), false]])
.withReducer(rootReducer, initialState.build())
.run();
expect(returnValue).toBe(false);
});
});
describe(closeErrorDialog, () => {
function subject(...args: Parameters<typeof expectSaga>) {
return expectSaga(...args).provide([[matchers.call.fn(openFirstConversation), null]]);
}
it('clears the join room error content when closeErrorDialog is called', async () => {
const initialState = new StoreBuilder().withChat({
joinRoomErrorContent: {
header: 'Existing Error',
body: 'Existing error message',
},
});
const { storeState } = await subject(closeErrorDialog)
.withReducer(rootReducer, initialState.build())
.put(clearJoinRoomErrorContent())
.run();
expect(storeState.chat.joinRoomErrorContent).toBeNull();
});
it('opens the first conversation', async () => {
await subject(closeErrorDialog).withReducer(rootReducer).call(openFirstConversation).run();
});
});
describe(joinRoom, () => {
it('joins the conversation', async () => {
const initialState = new StoreBuilder();
await expectSaga(joinRoom, '#convo-id')
.provide([
[call(apiJoinRoom, '#convo-id'), { success: true, response: { roomId: 'new-room-id' } }],
[matchers.call.fn(setWhenUserJoinedRoom), undefined],
])
.withReducer(rootReducer, initialState.build())
.call(setWhenUserJoinedRoom, 'new-room-id')
.run();
});
it('clears the join room error content if user successfully joins room', async () => {
const initialState = new StoreBuilder().withChat({
joinRoomErrorContent: { header: 'Previous Error', body: 'Previous error message' },
});
const { storeState } = await expectSaga(joinRoom, '#convo-id')
.provide([
[matchers.call.fn(apiJoinRoom), { success: true, response: { roomId: 'new-room-id' } }],
[matchers.call.fn(setWhenUserJoinedRoom), undefined],
])
.withReducer(rootReducer, initialState.build())
.run();
expect(storeState.chat.joinRoomErrorContent).toBeNull();
});
it('sets the join room error content if user fails to join room', async () => {
const initialState = new StoreBuilder().withChat({ joinRoomErrorContent: null });
const { storeState } = await expectSaga(joinRoom, '#convo-id')
.provide([[matchers.call.fn(apiJoinRoom), { success: false, response: 'UNKNOWN_ERROR' }]])
.withReducer(rootReducer, initialState.build())
.run();
expect(storeState.chat.joinRoomErrorContent).toStrictEqual(
ERROR_DIALOG_CONTENT[JoinRoomApiErrorCode.UNKNOWN_ERROR]
);
});
describe('error scenarios', () => {
const roomIdOrAlias = 'some-room-id-or-alias';
it('handles ROOM_NOT_FOUND error', async () => {
const initialState = new StoreBuilder().withChat({}).build();
const expectedErrorContent = ERROR_DIALOG_CONTENT[JoinRoomApiErrorCode.ROOM_NOT_FOUND];
const { storeState } = await expectSaga(joinRoom, roomIdOrAlias)
.withReducer(rootReducer, initialState)
.provide([
[matchers.call.fn(apiJoinRoom), { success: false, response: JoinRoomApiErrorCode.ROOM_NOT_FOUND }],
[matchers.call.fn(translateJoinRoomApiError), expectedErrorContent],
])
.run();
expect(storeState.chat.joinRoomErrorContent).toEqual(expectedErrorContent);
});
});
});
describe(validateActiveConversation, () => {
it('waits for channel load before validating', async () => {
testSaga(validateActiveConversation, 'convo-1')
.next()
.put(clearJoinRoomErrorContent())
.next()
.put(setIsJoiningConversation(true))
.next()
.call(waitForChatConnectionCompletion)
.next(true)
.call(performValidateActiveConversation, 'convo-1')
.next()
.put(setIsJoiningConversation(false))
.next()
.isDone();
});
it('does not validate if channel load fails', async () => {
testSaga(validateActiveConversation, 'convo-1')
.next()
.put(clearJoinRoomErrorContent())
.next()
.put(setIsJoiningConversation(true))
.next()
.call(waitForChatConnectionCompletion)
.next(false) // Channels did not load
.put(setIsJoiningConversation(false))
.next()
.isDone();
});
});
describe(waitForChatConnectionCompletion, () => {
it('returns true if channel list already loaded', () => {
testSaga(waitForChatConnectionCompletion).next().next(true).returns(true);
});
it('waits for load if channel list not yet loaded', () => {
testSaga(waitForChatConnectionCompletion)
.next()
.next(false)
.next('fake/chat/bus')
.next('fake/auth/bus')
// Conversation bus fires event
.next({ complete: {} })
.next()
.returns(true);
});
it('returns false if the channel load was aborted', () => {
testSaga(waitForChatConnectionCompletion)
.next()
.next(false)
.next('fake/chat/bus')
.next('fake/auth/bus')
// Auth bus fires user logout event
.next({ abort: {} })
.returns(false);
});
});