Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subsys: random: Correct Mutex define #86454

Merged
merged 1 commit into from
Mar 4, 2025
Merged

subsys: random: Correct Mutex define #86454

merged 1 commit into from
Mar 4, 2025
+1 −1

Conversation

zhaynxp
Copy link
Contributor

@zhaynxp zhaynxp commented Feb 28, 2025 •
edited by kartben
Loading

Correct Mutex ctr_lock defination as the wrong defination lead to sysworkq task not acquiring this mutex during bt init, which lead to BLE didn't work as described in issue #86444.

@zephyrbot zephyrbot added area: Random Random subsystem size: XS A PR changing only a single line of code labels Feb 28, 2025
@zhaynxp zhaynxp mentioned this pull request Feb 28, 2025
Closed
@tomi-font tomi-font linked an issue Feb 28, 2025 that may be closed by this pull request
BLE can't be used after erasing board and flash BT SHELL app #86444
Closed
@tomi-font tomi-font added the bug The issue is a bug, or the PR is fixing a bug label Feb 28, 2025
@tomi-font tomi-font added this to the v4.1.0 milestone Feb 28, 2025
@dleach02 dleach02 added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Feb 28, 2025
kartben
kartben approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

samples: in the commit message looks out of place?

@kartben kartben force-pushed the fix_ctl_lock_def branch from bb125f9 to fbd357c Compare March 3, 2025 15:04
@kartben
Copy link
Collaborator

kartben commented Mar 3, 2025

samples: in the commit message looks out of place?

just fixed it

@tomi-font
Copy link
Collaborator

samples: in the commit message looks out of place?

just fixed it

try again 😄

@fabiobaltieri
Copy link
Member

samples: in the commit message looks out of place?

just fixed it

try again 😄

🍿

@kartben
Copy link
Collaborator

kartben commented Mar 3, 2025 •
edited
Loading

@tomi-font mm sorry, what am I missing?

image

@tomi-font
Copy link
Collaborator

@tomi-font mm sorry, what am I missing?

You have subsys: in your commit title, which shouldn't be there. (https://github.com/zephyrproject-rtos/zephyr/actions/runs/13633909685/job/38107862211?pr=86454)
It's a bit surprising and first-time contributors tend to hit this. Welcome to Zephyr. 😉

@zhaynxp @fabiobaltieri
random: Correct Mutex define
7956946 
Correct Mutex ctr_lock defination as the wrong defination lead to
sysworkq task not acquiring this mutex during bt init, which lead to
BLE didn't work as described in issue zephyrproject-rtos#86444

Signed-off-by: Ying Zhang <ying.zhang_2@nxp.com>
@fabiobaltieri
Copy link
Member

It's a bit surprising and first-time contributors tend to hit this. Welcome to Zephyr. 😉

First time contributors? I do it all the time :-)

Pushed over this myself, let's how I messed up this time.

@kartben
Copy link
Collaborator

kartben commented Mar 4, 2025

@fabiobaltieri @tomi-font btw this basically means that something's wrong with Gitlint, as it should be catching it?

zephyr/.gitlint

Line 29 in fdb8b30

regex = ^(?!subsys:)(?!treewide:)(([^:]+):)(\s([^:]+):)*\s(.+)$

@kartben kartben merged commit 90c6eb1 into zephyrproject-rtos:main Mar 4, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben approved these changes

@ceolin ceolin ceolin approved these changes

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@jhedberg jhedberg jhedberg approved these changes

@dleach02 dleach02 dleach02 approved these changes

@bjarki-andreasen bjarki-andreasen bjarki-andreasen approved these changes

@tomi-font tomi-font tomi-font approved these changes

Assignees

@ceolin ceolin

Labels
area: Random Random subsystem bug The issue is a bug, or the PR is fixing a bug size: XS A PR changing only a single line of code Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

BLE can't be used after erasing board and flash BT SHELL app
9 participants
@zhaynxp @kartben @tomi-font @fabiobaltieri @ceolin @jhedberg @dleach02 @bjarki-andreasen @zephyrbot