bluetooth: hci: ipc: assert when building HCI IPC driver w/o ACL FC #86005
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelVPV
force-pushed
the
fail_hci_ipc_build_without_acl_flow_control
branch
from
4feebdd to
28536c8
Compare
zephyrbot
added
area: Bluetooth
area: Bluetooth HCI
zephyrbot
requested review from
alwa-nordic,
asbjornsabo,
Casper-Bonde-Bose,
cvinayak,
fredrikdanebjer,
hermabe,
HoZHel,
jhedberg,
kartben,
larsgk,
MariuszSkamra,
nashif,
sjanc,
Thalley and
theob-pro
cvinayak
requested changes
Mar 3, 2025
drivers/bluetooth/hci/ipc.c
Outdated
Comment on lines
21
to
23
| #if defined(CONFIG_BT_CONN) | ||
| BUILD_ASSERT(IS_ENABLED(CONFIG_BT_HCI_ACL_FLOW_CONTROL), | ||
| "IPC transport is not reliable without Controller-to-Host ACL flow control"); | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Suggested change
| #if defined(CONFIG_BT_CONN) | |
| BUILD_ASSERT(IS_ENABLED(CONFIG_BT_HCI_ACL_FLOW_CONTROL), | |
| "IPC transport is not reliable without Controller-to-Host ACL flow control"); | |
| #endif | |
| BUILD_ASSERT(!IS_ENABLED(CONFIG_BT_CONN) || IS_ENABLED(CONFIG_BT_HCI_ACL_FLOW_CONTROL), | |
| "IPC transport is not reliable without Controller-to-Host ACL flow control"); |
samples/bluetooth/hci_ipc/src/main.c
Outdated
Comment on lines
32
to
34
| #if defined(CONFIG_BT_CONN) | ||
| BUILD_ASSERT(IS_ENABLED(CONFIG_BT_HCI_ACL_FLOW_CONTROL), | ||
| "IPC transport is not reliable without Controller-to-Host ACL flow control"); | ||
| #endif | ||
|
|
PavelVPV
force-pushed
the
fail_hci_ipc_build_without_acl_flow_control
branch
from
28536c8 to
b92b51a
Compare
Thalley
reviewed
Mar 3, 2025
The HCI IPC driver is not reliable and can lead to lost ACL data if built without Controller-to-Host ACL flow control. This commit prevents building HCI IPC driver and hci_ipc sample without CONFIG_BT_HCI_ACL_FLOW_CONTROL. Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
PavelVPV
force-pushed
the
fail_hci_ipc_build_without_acl_flow_control
branch
from
b92b51a to
ae1bab2
Compare
Thalley
approved these changes
Mar 3, 2025
cvinayak
approved these changes
Mar 3, 2025
alwa-nordic
approved these changes
Mar 3, 2025
jhedberg
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HCI IPC driver is not reliable and can lead to lost ACL data if built without Controller-to-Host ACL flow control.
This commit prevents building HCI IPC driver and hci_ipc sample without CONFIG_BT_HCI_ACL_FLOW_CONTROL.
Relates to #86091