samples: fix dts missing in some NXP platforms #85445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
asemjonovs,
avisconti,
jeppenodgaard,
kartben,
MaureenHelm,
nashif,
teburd,
tristan-google,
ubieda and
yperess
|
@erwango , I update the fixture naming for magn_trig in this pr. |
hakehuang
force-pushed
the
disable_triger_mode
branch
from
aa4e1d1 to
fcacec1
Compare
yperess
previously approved these changes
Feb 9, 2025
MaureenHelm
requested changes
Feb 10, 2025
| @@ -0,0 +1,5 @@ | |||
| &fxls8974 { | |||
There was a problem hiding this comment.
New files need license/copyright headers
mimxrt1040_evk and twr_ke18f need board rework for trigger mode so dts need changed to add gpio trigger fixes: zephyrproject-rtos#85444 Signed-off-by: Hake Huang <hake.huang@oss.nxp.com>
the fixture name shall align with applications also update dts to support trig mode fixes: zephyrproject-rtos#85444 Signed-off-by: Hake Huang <hake.huang@oss.nxp.com>
hakehuang
force-pushed
the
disable_triger_mode
branch
2 times, most recently
from
9d91a74 to
253918c
Compare
MaureenHelm
approved these changes
Feb 11, 2025
|
@yperess please help to +1, I just update license pre Maureen's comments. Thanks |
kartben
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the dts missed properties, as those need board rework.
also fix a naming issue in magn_trig fixture.
fixes: #85444