-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] samples/net/sockets/http_server fails to build for several nrf5340/cpuapp/ns targets #85201
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
CONFIG_NET_SAMPLE_HTTPS_SERVICE=y | ||
|
||
# TLS configuration | ||
CONFIG_MBEDTLS=y | ||
CONFIG_MBEDTLS_BUILTIN=y | ||
CONFIG_MBEDTLS_ENABLE_HEAP=y | ||
CONFIG_MBEDTLS_HEAP_SIZE=60000 | ||
CONFIG_MBEDTLS_SSL_MAX_CONTENT_LEN=2048 | ||
CONFIG_NET_SOCKETS_SOCKOPT_TLS=y | ||
CONFIG_NET_SOCKETS_TLS_MAX_CONTEXTS=6 | ||
CONFIG_TLS_CREDENTIALS=y | ||
CONFIG_TLS_MAX_CREDENTIALS_NUMBER=5 | ||
CONFIG_PSA_WANT_ALG_ECDH=y | ||
CONFIG_PSA_WANT_ALG_ECDSA=y | ||
CONFIG_PSA_WANT_ECC_SECP_R1_256=y | ||
CONFIG_PSA_WANT_KEY_TYPE_ECC_PUBLIC_KEY=y | ||
CONFIG_PSA_WANT_KEY_TYPE_ECC_KEY_PAIR_IMPORT=y | ||
CONFIG_PSA_WANT_KEY_TYPE_ECC_KEY_PAIR_EXPORT=y | ||
CONFIG_PSA_WANT_KEY_TYPE_ECC_KEY_PAIR_GENERATE=y | ||
CONFIG_MBEDTLS_KEY_EXCHANGE_ECDHE_ECDSA_ENABLED=y | ||
CONFIG_PSA_WANT_ALG_CCM=y | ||
CONFIG_PSA_WANT_ALG_GCM=y | ||
CONFIG_MBEDTLS_PK_WRITE_C=y | ||
CONFIG_PSA_WANT_ALG_TLS12_PRF=y | ||
CONFIG_PSA_WANT_ALG_SHA_1=y | ||
CONFIG_PSA_WANT_ALG_SHA_256=y |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,3 +16,5 @@ common: | |
- nrf5340dk/nrf5340/cpuapp/ns # Excluding due to ROM overflow. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why was this removed, the sample will still not fit to that platform? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, correct. I initially thought that moving from legacy Mbed TLS support to TF-M's PSA Crypto on that platform could make the sample build successfully, but I just tried and it's not the case. So I need to revert this leftover. Thanks for noticing. |
||
tests: | ||
sample.net.sockets.http.server: {} | ||
sample.net.sockets.https.server: | ||
extra_args: EXTRA_CONF_FILE="overlay-tls.conf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we leave these and have a separate overlay config file for PSA options so that the legacy compilation works as before?
And then have separate section that tests the non-PSA and PSA compilations in
sample.yaml
file?So have something like
WDYT?