From 0dd1ac95b97cee673f459461d5d98dd19ed25ea5 Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Fri, 17 Jan 2025 13:16:36 -0800 Subject: [PATCH] Bluetooth: TBS: Fix -Wsometimes-uninitialized warning Building bluetooth.shell.audio.only_gtbs with clang warns: subsys/bluetooth/audio/tbs.c:1646:6: error: variable 'ret' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (param->gtbs) { ^~~~~~~~~~~ subsys/bluetooth/audio/tbs.c:1667:9: note: uninitialized use occurs here return ret; ^~~ subsys/bluetooth/audio/tbs.c:1646:2: note: remove the 'if' if its condition is always true if (param->gtbs) { ^~~~~~~~~~~~~~~~~ subsys/bluetooth/audio/tbs.c:1626:9: note: initialize the variable 'ret' to silence this warning int ret; ^ = 0 Signed-off-by: Tom Hughes --- subsys/bluetooth/audio/tbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subsys/bluetooth/audio/tbs.c b/subsys/bluetooth/audio/tbs.c index fb94678375fa..d581eaa86fdf 100644 --- a/subsys/bluetooth/audio/tbs.c +++ b/subsys/bluetooth/audio/tbs.c @@ -1623,7 +1623,7 @@ static bool valid_register_param(const struct bt_tbs_register_param *param) int bt_tbs_register_bearer(const struct bt_tbs_register_param *param) { - int ret; + int ret = -ENOEXEC; CHECKIF(!valid_register_param(param)) { LOG_DBG("Invalid parameters");