scripts: tests: Blackbox test expansion - platform #68765
Conversation
LukaszMrugala
force-pushed
the
lmrugalx_twister_blackbox_expansion_platform
branch
3 times, most recently
from
573f192 to
822d945
Compare
scripts/tests/twister_blackbox/test_data/boards/dummy_arch/dummy_platform/Kconfig.board
Outdated
Show resolved
Hide resolved
LukaszMrugala
force-pushed
the
lmrugalx_twister_blackbox_expansion_platform
branch
2 times, most recently
from
473bc86 to
60da1b4
Compare
There was a problem hiding this comment.
i'd suggest file paths aligned to what is currently with HWMv2 and use dummy names consistently
test_data/boards/dummy_vendor/dummy_board/board.yml
| board: | ||
| name: dummy | ||
| vendor: others | ||
| socs: [] |
There was a problem hiding this comment.
| board: | |
| name: dummy | |
| vendor: others | |
| socs: [] | |
| board: | |
| name: dummy_board | |
| vendor: dummy_vendor | |
| socs: | |
| - name: dummy_soc |
with HWMv2 the board's full name will be: dummy_board/dummy_soc
There was a problem hiding this comment.
You cannot use dummy_vendor; Zephyr has a vendor whitelist.
There was a problem hiding this comment.
Also, why would we want to fill out the socs list? It is not necessary for the test and requires adding new files, to avoid the ERROR: SoC 'dummy_soc' is not found, please ensure that the SoC exists and that soc-root containing 'dummy_soc' has been correctly defined.
There was a problem hiding this comment.
Those new files would also need to be outside the TEST_DATA folder, as soc-roots are hard-coded inside Twister and cannot be changed via a flag.
There was a problem hiding this comment.
I wonder should this twister blackbox test use subsys/testsuite folder then the same way as unit_testing does (see also #69786)
There was a problem hiding this comment.
OK, I have found unit_testing SoCs in $ZEPHYR_BASE/scripts/pylib/twister/soc. That path is one of the two hardcoded paths and I'll be able to put the dummy_soc definitions there.
However, the PR you've linked changes the hard-coded path from $ZEPHYR_BASE/scripts/pylib/twister/soc to $ZEPHYR_BASE/subsys/testsuite (still hardcoded, however). This means that these two PRs would be conflicting.
Do we want to use the current path ($ZEPHYR_BASE/scripts/pylib/twister/soc) and notify the other PR in case this one is merged first or use the proposed new path ($ZEPHYR_BASE/subsys/testsuite/soc) and wait for them to be merged first?
Or maybe even add another path to the hard-coded ones ($TEST_DATA/soc or something similar) so we can stay within TEST_DATA with our board and SoC definitions.
There was a problem hiding this comment.
In my opinion, it would be best to afford soc_root and arch_root the same treatment as board_roots; that is: option of adding more via Twister flags. But that's outside of scope of this PR.
There was a problem hiding this comment.
is this file needed for this blackbox test ?
There was a problem hiding this comment.
Required by documentation, but can be removed without the test failing.
There was a problem hiding this comment.
i think this file either should affect testing or not included.
| @@ -0,0 +1,4 @@ | |||
| name: dummy | |||
There was a problem hiding this comment.
| name: dummy | |
| name: dummy_board |
| name: dummy | ||
| vendor: dummy_vendor | ||
| arch: dummy_arch | ||
| identifier: dummy |
There was a problem hiding this comment.
| identifier: dummy | |
| identifier: dummy_board/dummy_soc |
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| #include "dummy.dts" |
There was a problem hiding this comment.
| #include "dummy.dts" |
There was a problem hiding this comment.
is this file needed for this blackbox test ?
There was a problem hiding this comment.
Required by documentation, but can be removed without the test failing.
LukaszMrugala
dismissed stale reviews from mdubielx, KamilxPaszkiet, and nashif
via
1842c37
LukaszMrugala
force-pushed
the
lmrugalx_twister_blackbox_expansion_platform
branch
3 times, most recently
from
7a2bb4a to
2b32d2e
Compare
Adds tests related to the Twister's platform selection: * -A, --board-root * -K, --force-platform * -p, --platform Signed-off-by: Lukasz Mrugala <lukaszx.mrugala@intel.com>
Blackbox tests related to platform choice now moved to test_platform.py: * test_emulation_only * test_exclude_platform Signed-off-by: Lukasz Mrugala <lukaszx.mrugala@intel.com>
LukaszMrugala
force-pushed
the
lmrugalx_twister_blackbox_expansion_platform
branch
from
2b32d2e to
69ddd62
Compare
KamilxPaszkiet
requested review from
mdubielx,
nashif and
golowanow
and removed request for
mdubielx
Adds tests related to the Twister's platform selection:
--board-root,-A,--force-platform,-K--platform,-pMoves other platform tests to the same file:
--emulation-only--exclude-platform,-P--all,-l