From a50476ca00fc95607db833ebcd3e5f983ef98fde Mon Sep 17 00:00:00 2001 From: Yong Cong Sin Date: Fri, 31 Jan 2025 15:30:15 +0800 Subject: [PATCH] logging: log_cmds: init uninitialized backend on `log_go()` For backends that do not autostart themselves, initialize & enable them on `log backend go`, so that they function properly. Signed-off-by: Yong Cong Sin Signed-off-by: Yong Cong Sin (cherry picked from commit f840a35be3438abdc18619c1f0609e7d7f98b20c) --- include/zephyr/logging/log_backend.h | 2 ++ subsys/logging/log_cmds.c | 14 +++++++++++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/include/zephyr/logging/log_backend.h b/include/zephyr/logging/log_backend.h index e772ad2b9c82..c68d210af735 100644 --- a/include/zephyr/logging/log_backend.h +++ b/include/zephyr/logging/log_backend.h @@ -83,6 +83,7 @@ struct log_backend_control_block { void *ctx; uint8_t id; bool active; + bool initialized; /* Initialization level. */ uint8_t level; @@ -140,6 +141,7 @@ static inline void log_backend_init(const struct log_backend *const backend) if (backend->api->init) { backend->api->init(backend); } + backend->cb->initialized = true; } /** diff --git a/subsys/logging/log_cmds.c b/subsys/logging/log_cmds.c index fd7997a84bd4..cc23a843eafe 100644 --- a/subsys/logging/log_cmds.c +++ b/subsys/logging/log_cmds.c @@ -341,7 +341,19 @@ static int log_go(const struct shell *sh, char **argv) { if (backend || !IS_ENABLED(CONFIG_LOG_FRONTEND)) { - log_backend_activate(backend, backend->cb->ctx); + if (!backend->cb->initialized) { + log_backend_init(backend); + while (log_backend_is_ready(backend) != 0) { + if (IS_ENABLED(CONFIG_MULTITHREADING)) { + k_msleep(10); + } + } + if (log_backend_is_ready(backend) == 0) { + log_backend_enable(backend, backend->cb->ctx, CONFIG_LOG_MAX_LEVEL); + } + } else { + log_backend_activate(backend, backend->cb->ctx); + } return 0; }