Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtensa: Add xtensa-amd_acp_6_0_adsp_zephyr-elf. #798

Conversation

DINESHKUMARK1
Copy link
Collaborator

This adds the config and overlay files to enable building the toolchain needed for the acp_6_0 board in Zephyr.

@DINESHKUMARK1 DINESHKUMARK1 force-pushed the topic-amd_acp_6_0 branch 5 times, most recently from a3ab174 to cb04a5c Compare September 26, 2024 10:17
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like gdb is finally building.

I have added a few comments; once addressed, I will merge this and try to get it into 0.16.9.

README.md Outdated
Comment on lines 17 to 20
- Xtensa (sample_controller, intel_ace15_mtpm, intel_tgl_adsp,
nxp_imx_adsp, nxp_imx8m_adsp, nxp_imx8ulp_adsp, nxp_rt500_adsp,
espressif_esp32, espressif_esp32s2, espressif_esp32s3, mt8195_adsp)
- Xtensa (sample_controller, amd_acp_6_0_adsp, intel_ace15_mtpm,
intel_tgl_adsp, nxp_imx_adsp, nxp_imx8m_adsp, nxp_imx8ulp_adsp,
nxp_rt500_adsp, espressif_esp32, espressif_esp32s2, espressif_esp32s3,
mt8195_adsp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A recent update removed the full enumeration of Xtensa toolchain variants.

This hunk can be removed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the topic-amd_acp_6_0 branch need to be updated before I apply my changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can push directly to the upstream topic-amd_acp_6_0, or alternatively open a PR to main from your fork branch with the final changes.

@stephanosio stephanosio added this to the 0.16.9 milestone Sep 27, 2024
@DINESHKUMARK1 DINESHKUMARK1 force-pushed the topic-amd_acp_6_0 branch 2 times, most recently from c8169c6 to d040933 Compare September 27, 2024 04:49
@DINESHKUMARK1 DINESHKUMARK1 deleted the topic-amd_acp_6_0 branch September 27, 2024 10:45
@DINESHKUMARK1 DINESHKUMARK1 restored the topic-amd_acp_6_0 branch September 27, 2024 10:46
@DINESHKUMARK1 DINESHKUMARK1 reopened this Sep 27, 2024
@DINESHKUMARK1 DINESHKUMARK1 deleted the topic-amd_acp_6_0 branch September 27, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants