Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: stm32wba: linklayer_plat: Migrate some functions to zephyr repo #260

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lib: stm32wba: linklayer_plat: Migrate some functions to zephyr repo #260

wants to merge 1 commit into from

Conversation

benothmn-st
Copy link
Collaborator

Migrate LINKLAYER_PLAT_EnableRadioIT, LINKLAYER_PLAT_DisableRadioIT, LINKLAYER_PLAT_EnableIRQ and LINKLAYER_PLAT_DisableIRQ to zephyr repo

@benothmn-st
lib: stm32wba: linklayer_plat: Migrate some functions to zephyr repo
fbee34c 
Migrate LINKLAYER_PLAT_EnableRadioIT, LINKLAYER_PLAT_DisableRadioIT,
LINKLAYER_PLAT_EnableIRQ and LINKLAYER_PLAT_DisableIRQ to zephyr repo

Signed-off-by: Nidhal BEN OTHMEN <nidhal.benothmen@st.com>
erwango
erwango requested changes Feb 17, 2025
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a matching Zephyr PR.

@benothmn-st
Copy link
Collaborator Author

benothmn-st commented Feb 17, 2025 •
edited
Loading

Please provide a matching Zephyr PR.

Thanks @erwango for the remark, here is the associated Zephyr PR #85802

@erwango
Copy link
Member

erwango commented Feb 17, 2025

Please provide a matching Zephyr PR.

Thanks @erwango for the remark, here is the associated Zephyr PR #85802

This is not sufficient. Zephyr repo PR PR should update west.yaml and points to current PR.

@zephyrbot zephyrbot mentioned this pull request Feb 17, 2025
Open
@benothmn-st
Copy link
Collaborator Author

Please provide a matching Zephyr PR.

Thanks @erwango for the remark, here is the associated Zephyr PR #85802

This is not sufficient. Zephyr repo PR PR should update west.yaml and points to current PR.

I add it now in the zephyr PR manifest

@erwango erwango added the DNM label Feb 17, 2025
asm5878
asm5878 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@asm5878 asm5878 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we are now removing all the not used func in a sigle #ifndef block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwango erwango erwango requested changes

@asm5878 asm5878 asm5878 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
DNM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benothmn-st @erwango @asm5878