Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add Base RevC 2xAEMvA and AEMv8-R FVPs to CI docker image #170

Merged
merged 3 commits into from
Feb 7, 2024
Merged

ci: Add Base RevC 2xAEMvA and AEMv8-R FVPs to CI docker image #170

merged 3 commits into from
Feb 7, 2024

Conversation

ithinuel
Copy link
Contributor

@ithinuel ithinuel commented Jan 31, 2024 •
edited
Loading

@stephanosio stephanosio self-requested a review January 31, 2024 18:27
stephanosio
stephanosio requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the offline discussion, could you please add a note about the redistribution of FVP now being allowed in the commit message?

stephanosio
stephanosio reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the offline discussion, could you please add a note about the redistribution of FVP now being allowed in the commit message?

Could you also address this?

@ithinuel
ci: Add Base RevC 2xAEMvA and AEMv8-R FVPs to CI docker image
3ceb423 
Signed-off-by: Wilfried Chauveau <wilfried.chauveau@arm.com>
@ithinuel
ci: Add ARMFVP_BIN_PATH env var definition
4dd44c6 
The cmake scripts use this variable to look up the binary

Signed-off-by: Wilfried Chauveau <wilfried.chauveau@arm.com>
@ithinuel ithinuel requested a review from stephanosio February 7, 2024 06:42
@stephanosio
Copy link
Member

Note: this does not include Corstone-300's FVP.

Is this comment outdated or am I missing something here?

stephanosio
stephanosio reviewed Feb 7, 2024
View reviewed changes
@ithinuel
ci: Add FVP for Corstone-300 & Corstone-310
432058f 
Signed-off-by: Wilfried Chauveau <wilfried.chauveau@arm.com>
@ithinuel
Copy link
Contributor Author

ithinuel commented Feb 7, 2024

Is this comment outdated or am I missing something here?

Oh, yes indeed. I edited the first post :)

@ithinuel ithinuel requested a review from stephanosio February 7, 2024 15:44
@stephanosio stephanosio merged commit fe0b04d into zephyrproject-rtos:main Feb 7, 2024
2 checks passed
@ithinuel ithinuel deleted the add-fvp-to-ci branch February 7, 2024 22:09
@stephanosio stephanosio mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanosio stephanosio stephanosio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ithinuel @stephanosio