base: Add nrf-regtool to the list of Python packages installed #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a discussion in Discord (https://discord.com/channels/720317445772017664/1196766845332619305/1196766847962464276) we concluded that there is no easy way of adding vendor-specific Python packages that are required to be executed during the build but should not be present in the standard requirements-*.txt files since they are specific to a single vendor. For now solve the issue by including the package by name in the Docker file, to have the package available for the PR that introduced the first IC that requires this package, the nRF54H20 (zephyrproject-rtos/zephyr#68043). Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
henrikbrixandersen
approved these changes
Jan 24, 2024
gmarull
reviewed
Jan 24, 2024
aescolar
approved these changes
Jan 24, 2024
stephanosio
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a discussion in Discord
(https://discord.com/channels/720317445772017664/1196766845332619305/1196766847962464276) we concluded that there is no easy way of adding vendor-specific Python packages that are required to be executed during the build but should not be present in the standard requirements-*.txt files since they are specific to a single vendor.
For now solve the issue by including the package by name in the Docker file, to have the package available for the PR that introduced the first IC that requires this package, the nRF54H20 (zephyrproject-rtos/zephyr#68043).