Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

Have check_compliance.py Kconfig whitelist live in zephyr repo #56

Open
galak opened this issue May 1, 2019 · 2 comments
Open

Have check_compliance.py Kconfig whitelist live in zephyr repo #56

galak opened this issue May 1, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@galak
Copy link
Contributor

galak commented May 1, 2019

Its a bit of a pain for developers to have to submit a fix the ci-tools/check_compliance.py repo/file for a Kconfig whitelist update. Can we move the whitelist to a file and keep it in the zephyr repo?

@galak galak added the enhancement New feature or request label May 1, 2019
@galak
Copy link
Contributor Author

galak commented May 1, 2019

@Sizurka, @sigvartmh fyi.

@ulfalizer
Copy link
Collaborator

ulfalizer commented May 2, 2019

The reason I didn't do that right away is that I think the right solution is to move ci-tools back into the main Zephyr repo instead. There will be other whitelists later on too, and it's annoying if you have to have a custom whitelist file for each, that supports comments, etc., and with the extra code that comes with that.

It feels like working around that ci-tools would be better to have as scripts/ci in the Zephyr repo, where it used to be.

I was kinda hoping that someone would take the initiative and move it back, but I could make a PR for it later otherwise.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants