Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the errors coming up in the pydantic branch #19

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fixing the errors coming up in the pydantic branch #19

merged 1 commit into from
Jun 13, 2024

Conversation

bcdurak
Copy link
Contributor

@bcdurak bcdurak commented Jun 12, 2024

  • There was a mismatch between the output signature of a step and the input signature of the next step.
  • Steps are being imported, even in the local case. I moved the import sky within the step, so it will not fail for people trying the template locally without skypilot.

@bcdurak bcdurak requested a review from avishniakov June 12, 2024 12:44
avishniakov
avishniakov approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@avishniakov avishniakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the same as before? Looks identical to #18

@bcdurak bcdurak merged commit cf674b5 into main Jun 13, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avishniakov avishniakov avishniakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcdurak @avishniakov