Skip to content

chore(menu): preview integration with container-menu@0.6.x using getAnchorProps [ DO NOT MERGE ] #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

chore(menu): preview integration with container-menu@0.6.x using getAnchorProps [ DO NOT MERGE ] #2019

wants to merge 8 commits into from

Conversation

ze-flo
Copy link
Contributor

@ze-flo ze-flo commented May 12, 2025 •
edited
Loading

Description

🚧 🚧 🚧 PREVIEW ONLY — DO NOT MERGE! 🚧 🚧 🚧

This PR previews the necessary changes to the Menu component to support navigation using the new getAnchorProps from useMenu in @zendeskgarden/container-menu@0.6.x.

Detail

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ⚫ renders as expected in dark mode
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

geotrev and others added 8 commits June 27, 2024 11:58
@geotrev
feat(dropdowns): enables menu item as link
da0bebe
@ze-flo
Merge branch 'main' of github.com:zendeskgarden/react-components into…
aeac589 
… george/menu-links

# Conflicts:
#	packages/dropdowns/src/elements/menu/Item.tsx
#	packages/dropdowns/src/views/combobox/StyledOption.ts
#	packages/dropdowns/src/views/menu/StyledItem.ts
#	packages/dropdowns/src/views/menu/StyledItemContent.ts
#	packages/dropdowns/src/views/menu/StyledItemIcon.ts
@ze-flo
refactor(menu): remove external link icon, fix keyboard behavior on l…
a2fb9cd 
…ink, clean up
@ze-flo
test(Menu): add Item with link specs
cf77156
@ze-flo
chore: clean up story data
15e0ba4
@ze-flo
chore: PR feedback
c4b0891
@ze-flo
refactor(dropdowns menu): use container-menu getAnchorProps getter
dd36fc7
@ze-flo
deps: use local copy of unpublished container-menu
05cd816
@ze-flo ze-flo mentioned this pull request May 12, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Internal 🌱
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ze-flo @geotrev