Add tests with Ruby 3.4 #585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razumau
force-pushed
the
ruby_3.4
branch
2 times, most recently
from
c70a11d to
a4a839c
Compare
Updates a spec that checks User#inspect output to work with the new Hash#inspect behaviour: ruby/ruby#10924
razumau
reviewed
Jan 10, 2025
Comment on lines
+458
to
+463
| expected_user_representation = if RUBY_VERSION >= "3.4" | ||
| "#<ZendeskAPI::User {\"foo\" => :bar}>" | ||
| else | ||
| "#<ZendeskAPI::User {\"foo\"=>:bar}>" | ||
| end | ||
| expect(ZendeskAPI::User.new(client, :foo => :bar).inspect).to eq(expected_user_representation) |
There was a problem hiding this comment.
This can be done differently:
expect(ZendeskAPI::User.new(client, :foo => :bar).inspect).to eq("#<ZendeskAPI::User #{{'foo' => :bar}}>")That is, we interpolate a hash directly in the expected output, and it match Hash#inspect behaviour. However, here we only have one such test, and we explicitly are interested in how User#inspect behaves, so I thought it would be better to have two branches.
codealchemy
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests with Ruby 3.4.
Updates a spec that checks User#inspect output to work with the new Hash#inspect behaviour: ruby/ruby#10924