Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEP9: Parse Metadata Objects #2866

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brokkoli71
Copy link
Member

This PR implements the following aspects of ZEP9 (Phase 1)

  • If metadata JSON contains invalid keys, or if a value object contains invalid keys, the zarr array should be rejected unless it contains `"must_understand": false``.
  • It should be possible to specify a value in metadata in the following ways
    • as a JSON object
    • As a string value (only if the object would have no attributes other than its name).

this will help to enable zarr extensions

TODOs in code:

  • read metadata fails accordingly (+test)
  • specifying metadata value works as string (+test)

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Feb 26, 2025
@brokkoli71 brokkoli71 changed the title prepare ZEP9: Parse Metadata Objects Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant