Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array creation with strings for filters, serializer, compressors #2839

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Array creation with strings for filters, serializer, compressors #2839

wants to merge 12 commits into from

Conversation

brokkoli71
Copy link
Member

@brokkoli71 brokkoli71 commented Feb 15, 2025 •
edited
Loading

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Feb 15, 2025
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Feb 15, 2025
brokkoli71
brokkoli71 commented Feb 18, 2025
View reviewed changes
src/zarr/core/array.py
_compressor = parse_compressor(compressor)

if filters is None:
_filters = None
elif filters == "auto":
_filters = default_filters
else:
if isinstance(filters, Iterable):
Copy link
Member Author

@brokkoli71 brokkoli71 Feb 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also checked in parse_filters, so I removed it

brokkoli71
brokkoli71 commented Feb 18, 2025
View reviewed changes
src/zarr/core/array.py
@@ -4264,24 +4264,13 @@ def _parse_chunk_encoding_v2(
elif isinstance(compressor, tuple | list) and len(compressor) == 1:
_compressor = parse_compressor(compressor[0])
else:
if isinstance(compressor, Iterable) and not isinstance(compressor, dict):
Copy link
Member Author

@brokkoli71 brokkoli71 Feb 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@brokkoli71 brokkoli71 marked this pull request as ready for review February 18, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array creation should take strings for filters, serializer, compressors
1 participant
@brokkoli71