Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement soft delete by replacing key with empty byte literal #2832

Closed
wants to merge 1 commit into from
Closed

implement soft delete by replacing key with empty byte literal #2832

wants to merge 1 commit into from

Conversation

asimchoudhary
Copy link

@asimchoudhary asimchoudhary commented Feb 14, 2025 •
edited
Loading

[Description of PR]
fixes : #828
TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Feb 14, 2025
@asimchoudhary asimchoudhary changed the title fix: implement soft delete by replacing key with empty byte literal implement soft delete by replacing key with empty byte literal Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementing ZipStore's __delitem__ via overwrite
1 participant
@asimchoudhary