Add codec pipeline strategy #2824
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
changed the title
github-actions
bot
added
the
needs release notes
dcherian
force-pushed
the
compressor-filter-strategies
branch
from
7cc1bc2 to
68ad945
Compare
dcherian
commented
Feb 13, 2025
Comment on lines
+105
to
+127
| zarr_codecs = st.one_of( | ||
| st.builds(zcodecs.ZstdCodec), | ||
| st.builds( | ||
| zcodecs.BloscCodec, | ||
| shuffle=st.builds( | ||
| zcodecs.BloscShuffle.from_int, num=st.integers(min_value=0, max_value=2) | ||
| ), | ||
| ), | ||
| st.builds(zcodecs.GzipCodec), | ||
| st.builds(zcodecs.Crc32cCodec), | ||
| ) | ||
| num_codecs_v2 = st.one_of( | ||
| st.builds(numcodecs.Zlib), | ||
| st.builds(numcodecs.LZMA), | ||
| st.builds(numcodecs.Zstd), | ||
| st.builds(numcodecs.Zlib), | ||
| ) | ||
| num_codecs_v3 = st.one_of( | ||
| st.builds(ncodecs.Blosc), | ||
| st.builds(ncodecs.LZMA), | ||
| # st.builds(ncodecs.PCodec), | ||
| # st.builds(ncodecs.ZFPY), | ||
| ) |
There was a problem hiding this comment.
This search space is quite large. How can we be strategic here?
I think we should test the codec pipeline separately with many different array types. For the arrays strategy, we could restrict ourselves to a much more limited choice (e.g. choose one among [a codec from numcodecs, a codec from zarr codecs, or None])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could use input on whether we can generate
filtersandcompressorsindependently of each other or whether they must be consistent with each other. Currently, I am assuming the latter and thecodecsstrategy creates bothfiltersandcompressorsTODO:
docs/user-guide/*.rstchanges/