-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sharding codec with fancy indexing #2817
Conversation
This reverts commit 1a30563.
thanks, this looks great. For posterity, could you explain what the bug was exactly? I don't actually remember offhand what fancy indexing is, so the logic of the fix isn't immediately obvious to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work.
#2822 passes when run with this PR merged
The hint I had for fixing this one was this comment: zarr-python/src/zarr/core/indexing.py Lines 1142 to 1143 in feeb08f
But CoordinateIndexer.sel_shape was not actually being used for unflattening in the sharding codec. This indexer specifically does a type of fancy/advanced indexing called inner/vectorised indexing.
|
Fixes #2816
TODO:
docs/user-guide/*.rst
changes/