Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify conda use in tests #1715

Closed
wants to merge 2 commits into from
Closed

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Mar 18, 2024

I noticed some redundant conda commands - conda-incubator/setup-miniconda should activate the right environment at each step, and make sure the right python is installed.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@dstansby dstansby marked this pull request as ready for review March 18, 2024 21:58
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (6105ef2) to head (5544486).

❗ Current head 5544486 differs from pull request most recent head d3457cd. Consider uploading reports for the commit d3457cd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1715   +/-   ##
=======================================
  Coverage   99.98%   99.99%           
=======================================
  Files          38       38           
  Lines       14640    14580   -60     
=======================================
- Hits        14638    14579   -59     
+ Misses          2        1    -1     

see 7 files with indirect coverage changes

@jhamman
Copy link
Member

jhamman commented May 7, 2024

Thanks for this @dstansby - as you now know, we're onto the v3 branch where we're not using conda, so I'm going to close this out.

@jhamman jhamman closed this May 7, 2024
@dstansby dstansby deleted the test-conda branch May 7, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants