From 24bd82a75a62a87ec34742b0b169348b8bd0b579 Mon Sep 17 00:00:00 2001
From: Dimitri Papadopoulos
 <3234522+DimitriPapadopoulos@users.noreply.github.com>
Date: Tue, 12 Mar 2024 19:28:23 +0100
Subject: [PATCH] Apply assorted ruff/refurb rules (FURB)

FURB113 Use `compressors.extend(...)` instead of repeatedly calling `compressors.append()`
FURB118 Use `operator.mul` instead of defining a lambda
FURB171 Membership test against single-item container
---
 zarr/_storage/v3_storage_transformers.py | 3 ++-
 zarr/meta.py                             | 4 ++--
 zarr/tests/test_core.py                  | 4 +---
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/zarr/_storage/v3_storage_transformers.py b/zarr/_storage/v3_storage_transformers.py
index 00467d44f9..75419c2556 100644
--- a/zarr/_storage/v3_storage_transformers.py
+++ b/zarr/_storage/v3_storage_transformers.py
@@ -1,5 +1,6 @@
 import functools
 import itertools
+import operator
 import os
 from typing import NamedTuple, Tuple, Optional, Union, Iterator
 
@@ -101,7 +102,7 @@ def __init__(self, _type, chunks_per_shard) -> None:
             if chunks_per_shard == ():
                 chunks_per_shard = (1,)
         self.chunks_per_shard = chunks_per_shard
-        self._num_chunks_per_shard = functools.reduce(lambda x, y: x * y, chunks_per_shard, 1)
+        self._num_chunks_per_shard = functools.reduce(operator.mul, chunks_per_shard, 1)
         self._dimension_separator = None
         self._data_key_prefix = None
 
diff --git a/zarr/meta.py b/zarr/meta.py
index 5430ab305d..ff6501b51a 100644
--- a/zarr/meta.py
+++ b/zarr/meta.py
@@ -232,7 +232,7 @@ def decode_fill_value(cls, v: Any, dtype: np.dtype, object_codec: Any = None) ->
                 return -np.inf
             else:
                 return np.array(v, dtype=dtype)[()]
-        elif dtype.kind in "c":
+        elif dtype.kind == "c":
             v = (
                 cls.decode_fill_value(v[0], dtype.type().real.dtype),
                 cls.decode_fill_value(v[1], dtype.type().imag.dtype),
@@ -283,7 +283,7 @@ def encode_fill_value(cls, v: Any, dtype: np.dtype, object_codec: Any = None) ->
             return int(v)
         elif dtype.kind == "b":
             return bool(v)
-        elif dtype.kind in "c":
+        elif dtype.kind == "c":
             c = cast(np.complex128, np.dtype(complex).type())
             v = (
                 cls.encode_fill_value(v.real, c.real.dtype, object_codec),
diff --git a/zarr/tests/test_core.py b/zarr/tests/test_core.py
index 730f724314..56333cb595 100644
--- a/zarr/tests/test_core.py
+++ b/zarr/tests/test_core.py
@@ -1995,9 +1995,7 @@ def test_attrs_n5_keywords(self):
     def test_compressors(self):
         compressors = [None, BZ2(), Zlib(), GZip(), MsgPack()]
         if LZMA:
-            compressors.append(LZMA())
-            compressors.append(LZMA(preset=1))
-            compressors.append(LZMA(preset=6))
+            compressors.extend((LZMA(), LZMA(preset=1), LZMA(preset=6)))
         for compressor in compressors:
             a1 = self.create_array(shape=1000, chunks=100, compressor=compressor)
             a1[0:100] = 1