-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StoreTests don't test Store.set_partial_values
#2859
Comments
I suspect we have |
Gotcha, thanks. Although it looks like only some store classes support it, and it's not part of the Would it be OK to add that to the
Yeah, IMO that seems a bit beyond the scope of the spec. I can see something like that being useful in the spec for examples, but not necessarily something that implementations should follow. |
actually I was wrong -- to me it seems like the following could work:
|
Zarr version
v3
Numcodecs version
na
Python Version
na
Operating System
Linux
Installation
source
Description
zarr.testing.store.StoreTests
provides some unit tests that any class implementing the Store interface should pass. Currently, there aren't any tests that exercise the abstractStore.set_partial_values
API.Steps to reproduce
Spotted this while working on zarr-v3 support in kvikio: https://github.com/TomAugspurger/kvikio/tree/tom/zarr-v3
Additional output
No response
The text was updated successfully, but these errors were encountered: