Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: LRUStoreCache removed in Zarr 3.0, not documented #2857

Open
ljwoods2 opened this issue Feb 24, 2025 · 1 comment
Open

DOC: LRUStoreCache removed in Zarr 3.0, not documented #2857

ljwoods2 opened this issue Feb 24, 2025 · 1 comment
Labels
documentation Improvements to the documentation help wanted Issue could use help from someone with familiarity on the topic

Comments

@ljwoods2
Copy link

Describe the issue linked to the documentation

I may be missing something, but noticed our CI was failing with Zarr v3 but can't find any deprecation warning or migration information for the zarr.storage.LRUStoreCache.

Is this no longer supported, or is there another way to do this?

Suggested fix for documentation

No response

@ljwoods2 ljwoods2 added documentation Improvements to the documentation help wanted Issue could use help from someone with familiarity on the topic labels Feb 24, 2025
@d-v-b
Copy link
Contributor

d-v-b commented Feb 24, 2025

sorry about that! looks like we forgot to add a deprecation to LRUStoreCache.

We have not implemented this for v3. In the longer term, I think we see caching as an important part of basic storage performance, and when we have have caching baked in to all stores, then a specialized LRUStoreCache store wouldn't make much sense.

But our future plans are not much use to you today. To get LRUStoreCache functionality going right now, I would look at the general purpose store wrapper class. If you subclassed WrapperStore and overrode __init__ to add cache setup logic, and overrode get(key) to add "check if key is in the cache, otherwise fetch it" logic then I think everything would work.

Let me know if that turns out to be bad advice, or you want more pointers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements to the documentation help wanted Issue could use help from someone with familiarity on the topic
Projects
None yet
Development

No branches or pull requests

2 participants