You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #2709 we ended up with a new keyword argument (compressor) in Group.create_array, unfortunately this creates confusion given that Group.create_array already takes a compressors kwarg, and create_array (the function Group.create_array ultimately invokes) only takes compressors.
New functions like create_array should be kept clear of confusing / redundant keyword arguments, and we should also ensure that Group.<func> has nearly the same signature as <func>, so for both these reasons I think we should hastily remove the compressor kwarg from Group.create_array, and ensure that the issue solved by #2709 can be solved via the compressors kwarg.
In #2709 we ended up with a new keyword argument (
compressor
) inGroup.create_array
, unfortunately this creates confusion given thatGroup.create_array
already takes acompressors
kwarg, andcreate_array
(the functionGroup.create_array
ultimately invokes) only takescompressors
.New functions like
create_array
should be kept clear of confusing / redundant keyword arguments, and we should also ensure thatGroup.<func>
has nearly the same signature as<func>
, so for both these reasons I think we should hastily remove thecompressor
kwarg fromGroup.create_array
, and ensure that the issue solved by #2709 can be solved via thecompressors
kwarg.cc @martindurant
The text was updated successfully, but these errors were encountered: