Skip to content

Commit

Permalink
array tests: handle different hexdigests from zlib-ng (#1678) (#1972)
Browse files Browse the repository at this point in the history
As explained in the issue, zlib-ng produces different hex digests
from original zlib. This adjusts the tests slightly to allow for
this.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
  • Loading branch information
AdamWill and dstansby authored Jan 16, 2025
1 parent c969f5c commit b00325e
Show file tree
Hide file tree
Showing 2 changed files with 280 additions and 185 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,17 @@ jobs:
matrix:
python-version: ['3.11', '3.12', '3.13']
numpy_version: ['>=2.1', '==1.24.*']
condadeps: ['']
exclude:
- python-version: '3.12'
numpy_version: '==1.24.*'
- python-version: '3.13'
numpy_version: '==1.24.*'
include:
- python-version: '3.13'
numpy_version: '>=2.1'
# to test alternate hexdigests with zlib-ng
condadeps: 'zlib-ng'
services:
redis:
image: redis
Expand Down Expand Up @@ -52,7 +58,7 @@ jobs:
- name: Create Conda environment with the rights deps
shell: "bash -l {0}"
run: |
conda create -n zarr-env python==${{matrix.python-version}} pip nodejs
conda create -n zarr-env python==${{matrix.python-version}} pip nodejs ${{matrix.condadeps}}
conda activate zarr-env
npm install -g azurite
- name: Install dependencies
Expand Down
Loading

0 comments on commit b00325e

Please sign in to comment.