Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify conda use in tests #674

Merged
merged 6 commits into from
Jan 4, 2025

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Dec 28, 2024

This:

  • Sets the defuault shell to avoid specifying it at every step
  • Doesn't create a new environment, but uses the default one provided by setup-miniconda
  • Puts back the install for pcodec on all Python versions, since wheels are out now

This simplifies the setup a fair bit, and cuts the total testing time by ~50% (9mins total vs 18 mins total for another recent build).

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (c5cf0c5) to head (44d6f57).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
- Coverage   99.92%   99.92%   -0.01%     
==========================================
  Files          62       62              
  Lines        2754     2752       -2     
==========================================
- Hits         2752     2750       -2     
  Misses          2        2              
Files with missing lines Coverage Δ
numcodecs/tests/test_zarr3.py 100.00% <ø> (ø)

@dstansby dstansby marked this pull request as ready for review December 28, 2024 21:39
@dstansby dstansby merged commit 6c0ea0f into zarr-developers:main Jan 4, 2025
26 checks passed
@dstansby dstansby deleted the simplify-test-conda branch January 4, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant