Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage check #546

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix coverage check #546

merged 1 commit into from
Jul 9, 2024

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Jul 9, 2024

Adds a "no cover" pragma in zfpy which resulted in CI issues

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (3f972d9) to head (2a36cd2).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
+ Coverage   99.82%   99.91%   +0.08%     
==========================================
  Files          59       59              
  Lines        2339     2336       -3     
==========================================
- Hits         2335     2334       -1     
+ Misses          4        2       -2     
Files with missing lines Coverage Δ
numcodecs/zfpy.py 100.00% <ø> (+4.00%) ⬆️

@normanrz normanrz marked this pull request as ready for review July 9, 2024 09:13
@normanrz normanrz enabled auto-merge (squash) July 9, 2024 09:14
@normanrz normanrz merged commit 146b69b into main Jul 9, 2024
45 checks passed
@normanrz normanrz deleted the zfpy-no-cover branch July 9, 2024 09:29
@normanrz normanrz mentioned this pull request Jul 9, 2024
7 tasks
@jakirkham
Copy link
Member

Thanks Norman! 🙏

DimitriPapadopoulos pushed a commit to DimitriPapadopoulos/numcodecs that referenced this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants