Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor kerchunk netCDF3 reader #397

Merged
merged 9 commits into from
Jan 29, 2025

Add Kerchunk's license to vendor dir

08e2eb8
Select commit
Loading
Failed to load commit list.
Merged

Vendor kerchunk netCDF3 reader #397

Add Kerchunk's license to vendor dir
08e2eb8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2025 in 0s

75.62% (target 75.00%)

View this Pull Request on Codecov

75.62% (target 75.00%)

Details

Codecov Report

Attention: Patch coverage is 52.87356% with 82 lines in your changes missing coverage. Please review.

Project coverage is 75.62%. Comparing base (fa3aeea) to head (08e2eb8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
virtualizarr/vendor/kerchunk/netCDF3.py 55.14% 61 Missing ⚠️
virtualizarr/vendor/kerchunk/utils.py 42.85% 20 Missing ⚠️
virtualizarr/readers/netcdf3.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
- Coverage   77.81%   75.62%   -2.19%     
==========================================
  Files          31       33       +2     
  Lines        1821     1994     +173     
==========================================
+ Hits         1417     1508      +91     
- Misses        404      486      +82
Files with missing lines Coverage Δ
virtualizarr/readers/netcdf3.py 85.71% <66.66%> (-3.76%) ⬇️
virtualizarr/vendor/kerchunk/utils.py 42.85% <42.85%> (ø)
virtualizarr/vendor/kerchunk/netCDF3.py 55.14% <55.14%> (ø)
View more details on Codecov