-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor kerchunk netCDF3 reader #397
Conversation
for more information, see https://pre-commit.ci
arr.attrs.update(original_attrs) | ||
|
||
|
||
def inline_array(store, threshold=1000, names=None, remote_options=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't need this at all, because we never use kerchunk's inlining (we use loadable_variables
instead).
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (52.87%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #397 +/- ##
==========================================
- Coverage 77.81% 75.62% -2.19%
==========================================
Files 31 33 +2
Lines 1821 1994 +173
==========================================
+ Hits 1417 1508 +91
- Misses 404 486 +82
|
Note that in the kerchunk compatibility PR the netCDF3 reader has now been updated to work with zarr-python v3. So we could just copy those changes here temporarily. |
I think you already suggested this elsewhere, but let's handle these updates in a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think we can ignore the code coverage gaps on the vendored readers for now
This reverts commit 95fce11.
Passes locally with zarr v2. But I think this will break for an env with zarr v3 in it.
docs/releases.rst
New functions/methods are listed inapi.rst
New functionality has documentation