Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roundtrip dict and json kerchunk tests without depending on kerchunk library #404

Closed
jsignell opened this issue Jan 30, 2025 · 1 comment
Labels
v3-migration Required for migration to Zarr-Python 3.0

Comments

@jsignell
Copy link
Contributor

It was discussed yesterday that a lot of the roundtrip test could run pretty much as-written if we just make a little helper that we can substitute in for xr.open_dataset(..., engine="kerchunk").

Making that substitution seems valuable because then a lot more of the test suite would run even in the absence of kerchunk.

This could be done as an alternative to or in addition to #376

@jsignell
Copy link
Contributor Author

Closing this - since as of fsspec/kerchunk#516 the backend code is much more significant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3-migration Required for migration to Zarr-Python 3.0
Projects
Development

Successfully merging a pull request may close this issue.

2 participants