feat: use versioned safe ser/deser #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniupop
approved these changes
Sep 25, 2024
| register_int_counter!("coprocessor_get_ciphertexts_count", "grpc calls for get ciphertexts endpoint").unwrap(); | ||
| static ref GET_CIPHERTEXTS_ERRORS: IntCounter = | ||
| register_int_counter!("coprocessor_get_ciphertexts_errors", "grpc errors while calling get ciphertexts").unwrap(); | ||
| static ref UPLOAD_INPUTS_COUNTER: IntCounter = register_int_counter!( |
There was a problem hiding this comment.
Beyond just this specific PR: a lot of the diffs are just formatting noise. Is there a tool that standardises formatting that we could agree on and use so we avoid this?
There was a problem hiding this comment.
I think we need to put a check in CI and not allow PRs without formatting.
There was a problem hiding this comment.
That would be best, yes
Use the versioned safe ser/deser tfhe-rs functions. Versioning might become part of safe ser/deser, but for now we better be explicit and not rely on that. `ProvenCompactCiphertextList` uses safe_(de)serialize() now as versioning is not supported in thfe-rs yet. Will move to versioned once available. `CompactPkePublicParams` uses (de)serialize_with_mode() as of now as versioning is not supported yet. Also, remove explicit thread local and Arc handling for server key - it is already an Arc internally, so it is cheap to clone.
dartdart26
force-pushed
the
petar/versioned-safe-ser-deser
branch
from
5d17ce3 to
42d9c16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the versioned safe ser/deser tfhe-rs functions. Versioning might become part of safe ser/deser, but for now we better be explicit and not rely on that.
ProvenCompactCiphertextListuses safe_(de)serialize() now as versioning is not supported in thfe-rs yet. Will move to versioned once available.CompactPkePublicParamsuses (de)serialize_with_mode() as of now as versioning is not supported yet.Also, remove explicit thread local and Arc handling for server key - it is already an Arc internally, so it is cheap to clone.