chore: remove computations.output_type #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudy-6-4
force-pushed
the
rudy/chore/alter_computations_drop_output_type
branch
4 times, most recently
from
a3f76f7 to
5322964
Compare
dartdart26
approved these changes
Feb 10, 2025
fhevm-engine/fhevm-db/migrations/20250131125649_add_large_ct_column.sql
Outdated
Show resolved
Hide resolved
rudy-6-4
force-pushed
the
rudy/chore/alter_computations_drop_output_type
branch
from
5322964 to
8c98662
Compare
rudy-6-4
force-pushed
the
rudy/chore/alter_computations_drop_output_type
branch
from
8c98662 to
94ac667
Compare
|
As an update I have added unknown type propagation. Note that type checking is no longer used with events. Events are converted directly to db row. The alternative could be to completely unplug type check in the grpc service. As events are generated after dynamic type check in the contracts it should not be an issue unless the contract TfheOperation is buggy. Note that the type error is still captured correctly after by tfhe workers. |
rudy-6-4
force-pushed
the
rudy/chore/alter_computations_drop_output_type
branch
3 times, most recently
from
85825b0 to
6f6cca9
Compare
rudy-6-4
force-pushed
the
rudy/chore/alter_computations_drop_output_type
branch
from
6f6cca9 to
7d101c5
Compare
it was only written to table but never used by tfhe_workers
rudy-6-4
force-pushed
the
rudy/chore/alter_computations_drop_output_type
branch
from
7d101c5 to
00e0e15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was only written to table but never used by tfhe_workers