Extended quantifiers refactor #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to declare an InstrumentationOperator rather than ExtendedQuantifier. InstrumentationOperator closely resembles the instrumentation operators given in the paper, and abstracts away from implementation details and CHCs.
ClauseInstrumenter currently does not deal with alien terms. It also needs to be tested. InstrumentationOperator currently also supports only a single set of ghost variables.
…st variable adder and initializer, but remaining parts are WIP.
Also adds two examples, one of which uses alien terms.
- Ghost variables were not tracking the right terms - fixed. - Alien terms are WIP - but split Boolean instrumentation operator from the general one encoding max/min/sum (which does not need to support alien terms).
A new AbstractExtendedQuantifier theory is added. This simplifies the code for subclasses. There was also conditional functionality, which is now split into separate classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for multiple ghost variable ranges is dropped for simplicity.