Skip to content

Commit

Permalink
KAFKA-17908 Tweak log messages in group metadata manager (apache#17652)
Browse files Browse the repository at this point in the history
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
  • Loading branch information
AndrewJSchofield authored Nov 3, 2024
1 parent f7f4e5b commit 0707c1f
Showing 1 changed file with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1502,7 +1502,7 @@ private void throwIfInstanceIdIsUnreleased(ConsumerGroupMember member, String gr
if (member.memberEpoch() != LEAVE_GROUP_STATIC_MEMBER_EPOCH) {
// The new member can't join.
log.info("[GroupId {}] Static member {} with instance id {} cannot join the group because the instance id is" +
" is owned by member {}.", groupId, receivedMemberId, receivedInstanceId, member.memberId());
" owned by member {}.", groupId, receivedMemberId, receivedInstanceId, member.memberId());
throw Errors.UNRELEASED_INSTANCE_ID.exception("Static member " + receivedMemberId + " with instance id "
+ receivedInstanceId + " cannot join the group because the instance id is owned by " + member.memberId() + " member.");
}
Expand Down Expand Up @@ -2706,11 +2706,11 @@ private CoordinatorResult<ConsumerGroupHeartbeatResponseData, CoordinatorRecord>
throwIfStaticMemberIsUnknown(member, instanceId);
throwIfInstanceIdIsFenced(member, groupId, memberId, instanceId);
if (memberEpoch == LEAVE_GROUP_STATIC_MEMBER_EPOCH) {
log.info("[GroupId {}] Static Member {} with instance id {} temporarily left the consumer group.",
log.info("[GroupId {}] Static member {} with instance id {} temporarily left the consumer group.",
group.groupId(), memberId, instanceId);
return consumerGroupStaticMemberGroupLeave(group, member);
} else {
log.info("[GroupId {}] Static Member {} with instance id {} left the consumer group.",
log.info("[GroupId {}] Static member {} with instance id {} left the consumer group.",
group.groupId(), memberId, instanceId);
return consumerGroupFenceMember(group, member, response);
}
Expand Down Expand Up @@ -3029,7 +3029,7 @@ private void scheduleConsumerGroupSessionTimeout(
sessionTimeoutMs,
TimeUnit.MILLISECONDS,
true,
() -> consumerGroupFenceMemberOperation(groupId, memberId, "the member session expired.")
() -> consumerGroupFenceMemberOperation(groupId, memberId, "the member session expired")
);
}

Expand All @@ -3049,7 +3049,7 @@ private void scheduleShareGroupSessionTimeout(
sessionTimeoutMs,
TimeUnit.MILLISECONDS,
true,
() -> shareGroupFenceMemberOperation(groupId, memberId, "the member session expired.")
() -> shareGroupFenceMemberOperation(groupId, memberId, "the member session expired")
);
}

Expand Down Expand Up @@ -3139,7 +3139,7 @@ private void scheduleConsumerGroupJoinTimeoutIfAbsent(
rebalanceTimeoutMs,
TimeUnit.MILLISECONDS,
true,
() -> consumerGroupFenceMemberOperation(groupId, memberId, "the classic member failed to join within the rebalance timeout.")
() -> consumerGroupFenceMemberOperation(groupId, memberId, "the classic member failed to join within the rebalance timeout")
);
}

Expand Down Expand Up @@ -3173,7 +3173,7 @@ private void scheduleConsumerGroupSyncTimeout(
rebalanceTimeoutMs,
TimeUnit.MILLISECONDS,
true,
() -> consumerGroupFenceMemberOperation(groupId, memberId, "the member failed to sync within timeout.")
() -> consumerGroupFenceMemberOperation(groupId, memberId, "the member failed to sync within timeout")
);
}

Expand Down Expand Up @@ -5739,7 +5739,7 @@ private CoordinatorResult<LeaveGroupResponseData, CoordinatorRecord> classicGrou
member = group.getOrMaybeCreateMember(memberId, false);
throwIfMemberDoesNotUseClassicProtocol(member);

log.info("[Group {}] Dynamic Member {} has left group " +
log.info("[Group {}] Dynamic member {} has left group " +
"through explicit `LeaveGroup` request; client reason: {}",
groupId, memberId, reason);
} else {
Expand All @@ -5753,7 +5753,7 @@ private CoordinatorResult<LeaveGroupResponseData, CoordinatorRecord> classicGrou
throwIfMemberDoesNotUseClassicProtocol(member);

memberId = member.memberId();
log.info("[Group {}] Static Member {} with instance id {} has left group " +
log.info("[Group {}] Static member {} with instance id {} has left group " +
"through explicit `LeaveGroup` request; client reason: {}",
groupId, memberId, instanceId, reason);
}
Expand Down

0 comments on commit 0707c1f

Please sign in to comment.