Skip to content

Commit

Permalink
Merge pull request #91 from ywx649999311/iss89
Browse files Browse the repository at this point in the history
Iss89
  • Loading branch information
ywx649999311 authored Sep 18, 2024
2 parents f27932f + f14401e commit 5a0ea5b
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# mac
*.DS_STORE

# dev folder
/dev/*
!/dev/00_template.ipynb
Expand Down
6 changes: 6 additions & 0 deletions src/eztao/carma/CARMATerm.py
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,12 @@ def get_rms_amp(self):
log_pars = self.get_parameter_vector()
return self.rms_amp(log_pars[: self.p], log_pars[self.p :])

def get_carma_parameter(self):
"""Return CARMA parameters in the natural sacle."""

log_pars = self.get_parameter_vector()
return _compute_exp(log_pars)

@staticmethod
def rms_amp(log_arpars, log_mapars):
"""Compute the RMS amplitude of a CARMA kernel
Expand Down
12 changes: 12 additions & 0 deletions tests/test_CARMATerm.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,3 +112,15 @@ def test_carma_fcoeffs():
with pytest.deprecated_call():
params = np.append(*kernel1.fcoeffs2carma(np.log(fcoeffs), 3))
assert np.allclose(np.log(params), kernel1.get_parameter_vector())


def test_carma_get_parameters():
"""Test the method CARMA_term.get_carma_parameter."""
input_ar = [3, 2.8, 0.8]
input_ma = [1, 5]
kernel1 = CARMA_term(np.log(input_ar), np.log(input_ma))

# test the equality of two functions
assert np.allclose(
np.exp(kernel1.get_parameter_vector()), kernel1.get_carma_parameter()
)

0 comments on commit 5a0ea5b

Please sign in to comment.