[DB-15395] Fix the IOPs calculation logic from considering seq_tup_read as reads to using number of scans(sequential and index) #2370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
The change is for the bug identified where
assess-migration
command was reporting a very large cluster(number of nodes) even for a substantially small clusters.Fixed the logic to make use of
seq_scan
andidx_scan
of pg_stat_user_tablesExperiments results captured in sheet - https://docs.google.com/spreadsheets/d/177NIv6UPsL_TmQ2J9nLTPiEU2p_nYHHnDZvRMefcnbk/edit?usp=sharing
For example: A simple case where seq scans are happening
Here earlier voyager was recommending - 34Nodes of 8vcpu instance types (screenshot 1)
Now recommending - 3 node 4vcpu instance types (screenshot 2)
screenshot 1:

screenshot 2:

Describe if there are any user-facing changes
No. Only the actual recommendations would change based on the new logic(statistics changed)
How was this pull request tested?
Does your PR have changes that can cause upgrade issues?