Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Target YB v2.23 with v2.25 #2363

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
2 changes: 1 addition & 1 deletion .github/workflows/issue-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
version: [2.23.1.0-b220, 2024.1.4.0-b108, 2024.2.1.0-b185, 2.20.9.0-b47, 2.25.0.0-b489]
version: [2.25.0.0-b489, 2024.1.4.0-b108, 2024.2.1.0-b185, 2.20.9.0-b47, 2.25.0.0-b489]
env:
YB_VERSION: ${{ matrix.version }}
YB_CONN_STR: "postgres://yugabyte:yugabyte@127.0.0.1:5433/yugabyte"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/misc-migtests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
AWS_SECRET_ACCESS_KEY: ${{ secrets.RAHULB_S3_SECRET_ACCESS_KEY }}
if: ${{ !cancelled() }}
run: |
versions=("2024.2.1.0-b185" "2.20.9.0-b47" "2024.1.4.0-b108" "2.23.1.0-b220")
versions=("2024.2.1.0-b185" "2.20.9.0-b47" "2024.1.4.0-b108" "2.25.0.0-b489")
for version in "${versions[@]}"; do
echo "Running tests on version $version"

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mysql-migtests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
run-mysql-migration-tests:
strategy:
matrix:
version: [2024.2.1.0-b185, 2.20.9.0-b47, 2024.1.4.0-b108, 2.23.1.0-b220]
version: [2024.2.1.0-b185, 2.20.9.0-b47, 2024.1.4.0-b108, 2.25.0.0-b489]
BETA_FAST_DATA_EXPORT: [0, 1]
env:
BETA_FAST_DATA_EXPORT: ${{ matrix.BETA_FAST_DATA_EXPORT }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pg-13-migtests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
run-pg-13-migration-tests:
strategy:
matrix:
version: [2024.2.1.0-b185, 2.20.9.0-b47, 2024.1.4.0-b108, 2.23.1.0-b220]
version: [2024.2.1.0-b185, 2.20.9.0-b47, 2024.1.4.0-b108, 2.25.0.0-b489]
BETA_FAST_DATA_EXPORT: [0, 1]
test_group:
- offline
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pg-17-migtests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
run-pg-17-migration-tests:
strategy:
matrix:
version: [2024.2.1.0-b185, 2.20.9.0-b47, 2024.1.4.0-b108, 2.23.1.0-b220]
version: [2024.2.1.0-b185, 2.20.9.0-b47, 2024.1.4.0-b108, 2.25.0.0-b489]
BETA_FAST_DATA_EXPORT: [0, 1]
test_group:
- offline
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ insert into fixed_point_types values (0.987546789,0,12397.64563,1264.12);
drop table if exists floating_point_types;
create table if not exists floating_point_types(id int,float_type float, double_type double, real_type REAL);
insert into floating_point_types values (1,0.456,0.12313,0.9);
insert into floating_point_types values (2,123456.456,0.1246533,1.9);
insert into floating_point_types values (2,123456.456,0.1246533,1.9);
insert into floating_point_types values (3,0,0,0);
insert into floating_point_types values (4,126.156,0.1,1.9999);

Expand Down
6 changes: 6 additions & 0 deletions migtests/tests/mysql/datatypes/validate
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/usr/bin/env python3

import yb
import os

def main():
yb.run_checks(migration_completed_checks)
Expand Down Expand Up @@ -143,6 +144,11 @@ def migration_completed_checks(tgt):
for table_name, row_count in EXPECTED_ROW_COUNT.items():
print(f"table_name: {table_name}, row_count: {got_row_count[table_name]}")
assert row_count == got_row_count[table_name]

tgtVersion = tgt.get_target_version()

if "2.25" in tgtVersion and os.environ.get('BETA_FAST_DATA_EXPORT') == '1':
EXPECTED_SUM_OF_COLUMN['floating_point_types']['float_type'] = '123582.61200000001'

for table_name, column_names_with_sum in EXPECTED_SUM_OF_COLUMN.items():
print(f"table_name: {table_name} ---- ")
Expand Down
18 changes: 15 additions & 3 deletions migtests/tests/pg/multiple-schemas/validate
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import yb
import common
import sys

live_migration = 'false'
def main():
Expand Down Expand Up @@ -145,16 +146,27 @@ def migration_completed_checks(tgt):
"orafce", "pageinspect", "pg_buffercache", "pg_cron", "pg_freespacemap", "pg_hint_plan", "pg_prewarm", "pg_stat_monitor",
"pg_stat_statements", "pg_trgm", "pg_visibility", "pgaudit", "pgcrypto", "pgrowlocks", "pgstattuple", "plpgsql",
"postgres_fdw", "refint", "seg", "sslinfo", "tablefunc", "tcn", "timetravel", "tsm_system_rows",
"tsm_system_time", "unaccent", "uuid-ossp", "yb_pg_metrics", "yb_test_extension" ]
"tsm_system_time", "unaccent", "uuid-ossp", "yb_pg_metrics", "yb_test_extension", "vector" ]
extensions = tgt.get_available_extensions()
print(f"expected extensions: {expectedExtensions}")
print(f"reported extensions: {extensions}")
tgtVersion = tgt.get_target_version()
print(f"target version: {tgtVersion}")
if "2.16" in tgtVersion:
expectedExtensions.remove("hll")
if "2.25" in tgtVersion:
expectedExtensions.remove("timetravel")
expectedExtensions.extend(["pg_partman", "pg_walinspect", "old_snapshot", "pgtap", "yb_ycql_utils", "pg_surgery", "yb_xcluster_ddl_replication"])
if "2024.2" in tgtVersion:
expectedExtensions.extend(["pg_partman", "pgtap", "yb_ycql_utils", "yb_xcluster_ddl_replication"])
if "2024.1" in tgtVersion:
expectedExtensions.extend(["yb_ycql_utils"])
for extension in expectedExtensions:
assert extension in extensions, f"expected extension is not reported: {extension}"

# Check for extra/unexpected extensions
extra_extensions = set(extensions) - set(expectedExtensions)
if extra_extensions:
print(f"ERROR: Unexpected extensions found: {extra_extensions}")
sys.exit(1) # Exit with error status

def change_expected_values_for_live_migration():
del EXPECTED_ROW_COUNT["Mixed_Case_Table_Name_Test"]
Expand Down
Loading