Fixed the issue for bulk-assessments using the --yes flag with bulk assessment tests #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
atharva-kurhade-yb
changed the title
|
Started a Jenkins Pipeline to test Oracle Bulk Assessments |
Comment on lines
1740
to
1712
| if utils.AskPrompt("No target-db-version has been specified.\nDo you want to continue with the latest stable YugabyteDB version:", ybversion.LatestStable.String()) { | ||
| targetDbVersion = ybversion.LatestStable | ||
| return nil | ||
| } else { | ||
| utils.ErrExit("Aborting..") | ||
| return nil | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I think you might need to rebase your branch with main.
There was a problem hiding this comment.
I have rebased the branch. Would this have affected the jenkins build or PR?
atharva-kurhade-yb
requested review from
makalaaneesh,
sanyamsinghal,
shubham-yb and
priyanshi-yb
atharva-kurhade-yb
force-pushed
the
atharva/target-db-version-prompt-for-analyze-schema-and-assess-migration
branch
from
5696b64 to
71a884a
Compare
sanyamsinghal
approved these changes
Jan 30, 2025
makalaaneesh
approved these changes
Jan 30, 2025
atharva-kurhade-yb
deleted the
atharva/target-db-version-prompt-for-analyze-schema-and-assess-migration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Added --yes flag to bulk migration test in functions.sh
Describe if there are any user-facing changes
How was this pull request tested?
Does your PR have changes that can cause upgrade issues?