Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression/Bug fixes in Oracle html report due to recent refactoring #2248

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

sanyamsinghal
Copy link
Collaborator

@sanyamsinghal sanyamsinghal commented Jan 27, 2025

Describe the changes in this pull request

  1. Assigning empty value to Impact column for Oracle assessment report

    • centre-aligned the impact column values
  2. Populate Issue Type for Oracle unsupported object type cases

https://yugabyte.atlassian.net/browse/DB-15035
https://yugabyte.atlassian.net/browse/DB-15037

image

Describe if there are any user-facing changes

NA

How was this pull request tested?

Manually verified the case.
Existing tests are enough, but need to be updated to check the assessment issue field to avoid these issue.

Does your PR have changes that can cause upgrade issues?

Component Breaking changes?
MetaDB Yes/No
Name registry json Yes/No
Data File Descriptor Json Yes/No
Export Snapshot Status Json Yes/No
Import Data State Yes/No
Export Status Json Yes/No
Data .sql files of tables Yes/No
Export and import data queue Yes/No
Schema Dump Yes/No
AssessmentDB Yes/No
Sizing DB Yes/No
Migration Assessment Report Json Yes/No
Callhome Json Yes/No
YugabyteD Tables Yes/No
TargetDB Metadata Tables Yes/No

@sanyamsinghal sanyamsinghal marked this pull request as ready for review January 27, 2025 08:17
@sanyamsinghal sanyamsinghal self-assigned this Jan 27, 2025
Copy link
Contributor

@priyanshi-yb priyanshi-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

@sanyamsinghal sanyamsinghal merged commit bbf4191 into main Jan 27, 2025
68 checks passed
@sanyamsinghal sanyamsinghal deleted the sanyam/oracle-html branch January 27, 2025 09:11
sanyamsinghal added a commit that referenced this pull request Jan 27, 2025
…2248)

* Assigning empty value to Impact column for Oracle assessment report
- centre-aligned the impact column values

* Populate Issue Type for Oracle unsupported object type cases
sanyamsinghal added a commit that referenced this pull request Jan 27, 2025
…2248) (#2250)

* Assigning empty value to Impact column for Oracle assessment report
- centre-aligned the impact column values

* Populate Issue Type for Oracle unsupported object type cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants