Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Assessment Issue in assessment report json #2237

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

sanyamsinghal
Copy link
Collaborator

@sanyamsinghal sanyamsinghal commented Jan 23, 2025

Describe the changes in this pull request

Describe if there are any user-facing changes

Yes, assessment json report will have new field AssessmentIssues, for now this is redudant since we have old fields also.
Once we verify and upate the existing tests then we can remove this field

How was this pull request tested?

Existing tests passing is enough

Does your PR have changes that can cause upgrade issues?

Component Breaking changes?
MetaDB Yes/No
Name registry json Yes/No
Data File Descriptor Json Yes/No
Export Snapshot Status Json Yes/No
Import Data State Yes/No
Export Status Json Yes/No
Data .sql files of tables Yes/No
Export and import data queue Yes/No
Schema Dump Yes/No
AssessmentDB Yes/No
Sizing DB Yes/No
Migration Assessment Report Json Yes <--
Callhome Json Yes/No
YugabyteD Tables Yes/No
TargetDB Metadata Tables Yes/No

Copy link
Collaborator

@makalaaneesh makalaaneesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment.
Pls verify that yugabyted UI is not broken.

@sanyamsinghal sanyamsinghal merged commit 26eb484 into main Jan 23, 2025
67 checks passed
@sanyamsinghal sanyamsinghal deleted the sanyam/assess-json branch January 23, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants