Added validation for MigrationComplexityExplanation in all pg tests #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e assessment/bulk-assessment tests
priyanshi-yb
approved these changes
Jan 22, 2025
| @@ -254,7 +254,7 @@ const explainTemplateHTML = ` | |||
| </p> | |||
| ` | |||
|
|
|||
| const explainTemplateText = `Reasoning: {{ .ComplexityRationale }}` | |||
There was a problem hiding this comment.
nit: this is not a template string now, its a string for ComplexityRationale, maybe we can avoid the whole template formating and execution for this.
So we can just return this ComplexityRationale in buildMigrationComplexityExplanation for this case
There was a problem hiding this comment.
yeah, will cleanup in further PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Describe if there are any user-facing changes
NO
How was this pull request tested?
Exisiting tests(unit, end-to-end) passing.
Does your PR have changes that can cause upgrade issues?