Added FixedIn version for issues fixed in the 2.25 YB version #2214

priyanshi-yb · 2025-01-21T09:53:06Z

Describe the changes in this pull request

Supporting the 2.25 YB version by adding the fixed in version to the issues fixed in the YB 2.25 release https://docs.yugabyte.com/preview/develop/pg15-features/
fixes Support 2.25 for assess-migration and analyze-schema and updated issues fixed in version #2209
The following issues are fixed in -

Stored generated columns
Before Row triggers on partitioned tables
Multi-range datatypes
Security invoker issues
Deterministic attribute with CREATE COLLATION
Foreign key references to partitioned tables
SQL body in function
Unique Nulls Not distinct
Regex functions
Range aggregate functions
Jsonb subscripting
Copy FROM .. WHERE
CTE with Materialized clause

Separated out the any_value, and range_.._agg aggregate functions into two separate issues: range functions are PG15 feature and fixed in 2.25 release and any_value is PG16 feature.

Describe if there are any user-facing changes

Fixed issues won't be reported if target-db-version is 2.25 and in the other case the report will show the fixed version for the issue

How was this pull request tested?

current tests should be enough

Does your PR have changes that can cause upgrade issues?

Component	Breaking changes?
MetaDB	No
Name registry json	No
Data File Descriptor Json	No
Export Snapshot Status Json	No
Import Data State	No
Export Status Json	No
Data .sql files of tables	No
Export and import data queue	No
Schema Dump	No
AssessmentDB	No
Sizing DB	No
Migration Assessment Report Json	No
Callhome Json	No
YugabyteD Tables	No
TargetDB Metadata Tables	No

…f more

makalaaneesh · 2025-01-23T05:57:10Z

yb-voyager/src/query/queryissue/constants.go

@@ -49,8 +49,11 @@ const (
 	FOREIGN_TABLE                                  = "FOREIGN_TABLE"
 	INHERITANCE                                    = "INHERITANCE"

-	AGGREGATE_FUNCTION             = "AGGREGATE_FUNCTION"
-	AGGREGATION_FUNCTIONS_NAME     = "Aggregate Functions"
+	ANY_VALUE_AGGREGATE_FUNCTION      = "ANY_VALUE_AGGREGATE_FUNCTION"


Can you provide context behind this change to have separate issues? Pls add to PR description as well.

yeah will add it to the PR description, but the reason for separating it out is that any_value is a PG16 feature and range_agg.. functions are PG15 ones and are supported in 2.25
so we have to add the version for range ones only. So I thought it would be better to separate them now.

makalaaneesh · 2025-01-23T06:00:35Z

yb-voyager/src/query/queryissue/issues_ddl.go

@@ -540,6 +555,10 @@ var deterministicOptionCollationIssue = issue.Issue{
 	Suggestion:  "This feature is not supported in YugabyteDB yet",
 	GH:          "https://github.com/yugabyte/yugabyte-db/issues/25575",
 	DocsLink:    "https://docs.yugabyte.com/preview/yugabyte-voyager/known-issues/postgresql/#postgresql-12-and-later-features",
+	MinimumVersionsFixedIn: map[string]*ybversion.YBVersion{
+		ybversion.SERIES_2_25: ybversion.V2_25_0_0, // TODO: understand why docs says coming soon non-deterministic collation but the CREATE COLLAITON works on 2.25


If we don't have clarity, i would err on the side of reporting the issue, and then later fixing it, rather than marking it as fixed.

As discussed in standup, anything is fine, since you have already marked them as fixed, it should be okay 👍

makalaaneesh · 2025-01-23T06:01:41Z

yb-voyager/src/query/queryissue/issues_ddl_test.go

@@ -341,6 +360,39 @@ func testUniqueNullsNotDistinctIssue(t *testing.T) {
 	assertErrorCorrectlyThrownForIssueForYBVersion(t, err, "syntax error", uniqueNullsNotDistinctIssue)
 }

+func testBeforeRowTriggerOnPartitionedTable(t *testing.T) {


was this just a miss?

this issue was PG12 feature and added before we had this issues-intergrations pipeline so we didn't had the test case for it but this is fixed in 2.25 as I can see on the docs, so added test case and marked it as fixed.

Awesome thanks!

makalaaneesh · 2025-01-23T06:02:33Z

yb-voyager/src/query/queryissue/issues_dml.go

@@ -228,6 +255,9 @@ var cteWithMaterializedIssue = issue.Issue{
 	Suggestion:  "No workaround available right now",
 	GH:          "https://github.com/yugabyte/yugabyte-db/issues/25575",
 	DocsLink:    "https://docs.yugabyte.com/preview/yugabyte-voyager/known-issues/postgresql/#postgresql-12-and-later-features",
+	MinimumVersionsFixedIn: map[string]*ybversion.YBVersion{
+		ybversion.SERIES_2_25:   ybversion.V2_25_0_0, //TODO: understand in NOT MATERIALIZED works as expected internally


let's discuss this

makalaaneesh · 2025-01-23T06:03:42Z

yb-voyager/src/query/queryissue/issues_dml_test.go

@@ -108,9 +138,38 @@ func testCopyFromWhereIssue(t *testing.T) {
 	conn, err := getConn()
 	assert.NoError(t, err)

+	tmpFile, err := os.CreateTemp("/tmp", "copy_where_example.csv")


I just wrote a CreateTempFile in testutils. See if we can use that?

Will take a look

makalaaneesh · 2025-01-23T07:48:23Z

yb-voyager/src/query/queryissue/issues_dml.go

+	Impact:      constants.IMPACT_LEVEL_2,
+	Description: RANGE_AGGREGATE_FUNCTION_ISSUE_DESCRIPTION,
+	Suggestion:  "",
+	GH:          "https://github.com/yugabyte/yugabyte-db/issues/25575",


we should create separate GH as well then

we don't have separate GH for PG15-17 issues as we had decided to have a single GH and docs link for these features

sanyamsinghal

took a quick look, LGTM.
Lets wait for @makalaaneesh approval before merge.

sanyamsinghal · 2025-01-23T07:55:35Z

yb-voyager/src/query/queryissue/constants.go

+	ANY_VALUE_AGGREGATE_FUNCTION_ISSUE_DESCRIPTION = "any_value function are not supported yet in YugabyteDB"
+	RANGE_AGGREGATE_FUNCTION_ISSUE_DESCRIPTION     = "range_agg, range_intersect_agg function are not supported yet in YugabyteDB"


please add a fullstop after each description.
Reason being: in assessment we combination it like description + " " + suggestion
So both should be complete sentence in themselves

priyanshi-yb added 13 commits January 21, 2025 15:17

run issues -integration tests with 2.25

2debf43

Merge branch 'main' into priyanshi/2.25-in-yb-version

80a69ee

add fixed in for the issues fixed in 2.25

8980396

build

e19a6a9

fix copy on where and on error test case and add versions to couple o…

abc7333

…f more

separated out the any_value and range agg functions

cfc2e05

changed copy where case to match with error msg casing

a3b67f4

fixed a few more cases

17ad8ca

Merge branch 'main' into priyanshi/2.25-in-yb-version

5fdee56

fixed new cases

4f79e8d

error msgs as per tdb version

769a038

trial

ab48233

try

e22d126

priyanshi-yb force-pushed the priyanshi/2.25-in-yb-version branch from 78dde9b to e22d126 Compare January 22, 2025 09:34

priyanshi-yb added 5 commits January 22, 2025 15:28

fix

72771d3

fix

064f01b

fixed in for issues_dml/issues_ddl

1184455

fixed before row trigger on partitioned table on 2.25

11fe8e0

fix cte issue

fae1fd1

priyanshi-yb changed the title ~~run issues against 2.25~~ Adding FixedIn version for issues fixed in the 2.25 YB version Jan 22, 2025

priyanshi-yb requested a review from makalaaneesh January 22, 2025 13:41

priyanshi-yb marked this pull request as ready for review January 22, 2025 14:02

priyanshi-yb changed the title ~~Adding FixedIn version for issues fixed in the 2.25 YB version~~ Added FixedIn version for issues fixed in the 2.25 YB version Jan 22, 2025

priyanshi-yb requested a review from sanyamsinghal January 22, 2025 14:10

makalaaneesh reviewed Jan 23, 2025

View reviewed changes

priyanshi-yb added 2 commits January 23, 2025 13:10

Merge branch 'main' into priyanshi/2.25-in-yb-version

e895f33

review comment

d8099f2

makalaaneesh reviewed Jan 23, 2025

View reviewed changes

priyanshi-yb requested a review from makalaaneesh January 23, 2025 07:51

commit missed files

8c97917

priyanshi-yb force-pushed the priyanshi/2.25-in-yb-version branch from b1854ff to 8c97917 Compare January 23, 2025 08:03

sanyamsinghal approved these changes Jan 23, 2025

View reviewed changes

makalaaneesh approved these changes Jan 23, 2025

View reviewed changes

add fullstop to the some descriptions

8bb03a5

priyanshi-yb merged commit 37fb28b into main Jan 23, 2025
68 checks passed

priyanshi-yb deleted the priyanshi/2.25-in-yb-version branch January 23, 2025 10:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added FixedIn version for issues fixed in the 2.25 YB version #2214

Added FixedIn version for issues fixed in the 2.25 YB version #2214

priyanshi-yb commented Jan 21, 2025 •

edited

Loading

makalaaneesh Jan 23, 2025

priyanshi-yb Jan 23, 2025 •

edited

Loading

makalaaneesh Jan 23, 2025

makalaaneesh Jan 23, 2025

makalaaneesh Jan 23, 2025

priyanshi-yb Jan 23, 2025 •

edited

Loading

makalaaneesh Jan 23, 2025

makalaaneesh Jan 23, 2025

makalaaneesh Jan 23, 2025

priyanshi-yb Jan 23, 2025

makalaaneesh Jan 23, 2025

priyanshi-yb Jan 23, 2025

sanyamsinghal left a comment

sanyamsinghal Jan 23, 2025

		ANY_VALUE_AGGREGATE_FUNCTION_ISSUE_DESCRIPTION = "any_value function are not supported yet in YugabyteDB"
		RANGE_AGGREGATE_FUNCTION_ISSUE_DESCRIPTION = "range_agg, range_intersect_agg function are not supported yet in YugabyteDB"

Added FixedIn version for issues fixed in the 2.25 YB version #2214

Added FixedIn version for issues fixed in the 2.25 YB version #2214

Conversation

priyanshi-yb commented Jan 21, 2025 • edited Loading

Describe the changes in this pull request

Describe if there are any user-facing changes

How was this pull request tested?

Does your PR have changes that can cause upgrade issues?

Choose a reason for hiding this comment

priyanshi-yb Jan 23, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

priyanshi-yb Jan 23, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sanyamsinghal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

priyanshi-yb commented Jan 21, 2025 •

edited

Loading

priyanshi-yb Jan 23, 2025 •

edited

Loading

priyanshi-yb Jan 23, 2025 •

edited

Loading