Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB-9827 synchronize flushing of snapshot writers in flusher thread with closing snapshot files #1302

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

makalaaneesh
Copy link
Collaborator

WIthout synchronization, there is a possibility of the flusher thread trying to flush an already closed file stream.

@makalaaneesh makalaaneesh changed the title synchronize flushing of snapshot writers in flusher thread with closing snapshot files DB-9827 synchronize flushing of snapshot writers in flusher thread with closing snapshot files Jan 31, 2024
@makalaaneesh makalaaneesh requested a review from amit-yb February 1, 2024 05:32
@makalaaneesh makalaaneesh marked this pull request as ready for review February 1, 2024 05:32
Copy link
Contributor

@amit-yb amit-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@makalaaneesh makalaaneesh merged commit afda6c2 into main Feb 1, 2024
13 of 15 checks passed
@makalaaneesh makalaaneesh deleted the aneesh/fix_flush_close_sync_issue branch February 1, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants