review comments

yugabyte · Feb 5, 2025 · 9d58b8c · 9d58b8c
1 parent 28eee46
commit 9d58b8c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/yb-voyager/src/query/queryissue/constants.go b/yb-voyager/src/query/queryissue/constants.go
@@ -179,6 +179,7 @@ const (
 	NON_DETERMINISTIC_COLLATION_ISSUE_DESCRIPTION                    = "Non-Deterministic collations are not yet supported in YugabyteDB."
 	FOREIGN_KEY_REFERENCES_PARTITIONED_TABLE_ISSUE_DESCRIPTION       = "Foreign key references to partitioned table are not yet supported in YugabyteDB."
 	UNIQUE_NULLS_NOT_DISTINCT_ISSUE_DESCRIPTION                      = "Unique constraint on columns with NULL values is not yet supported in YugabyteDB."
+	DATABASE_OPTIONS_DESCRIPTION                                     = "Database options (%s) introduced in PostgreSQL 12 and later are not supported yet in YugabyteDB."
 )
 
 // Object types

diff --git a/yb-voyager/src/query/queryissue/issues_ddl.go b/yb-voyager/src/query/queryissue/issues_ddl.go
@@ -634,14 +634,15 @@ func NewUniqueNullsNotDistinctIssue(objectType string, objectName string, sqlSta
 }
 
 /*
-Database options works on 2.25 but not marking it as supported in 2.25 for now but as per this ticket 
- https://github.com/yugabyte/yugabyte-db/issues/25541, DB will be blocking this support so its not supported technically
+Database options works on 2.25 but not marking it as supported in 2.25 for now but as per this ticket
+
+	https://github.com/yugabyte/yugabyte-db/issues/25541, DB will be blocking this support so its not supported technically
 */
 var databaseOptionsPG15Issue = issue.Issue{
 	Type:        DATABASE_OPTIONS_PG15,
 	Name:        "Database options",
 	Impact:      constants.IMPACT_LEVEL_2,
-	Description: "Database options (%s) introduced in PostgreSQL 12 and later are not supported yet in YugabyteDB.",
+	Description: DATABASE_OPTIONS_DESCRIPTION,
 	Suggestion:  "",
 	GH:          "https://github.com/yugabyte/yugabyte-db/issues/25575",
 	DocsLink:    "https://docs.yugabyte.com/preview/yugabyte-voyager/known-issues/postgresql/#postgresql-12-and-later-features",
@@ -660,7 +661,7 @@ var databaseOptionsPG17Issue = issue.Issue{
 	Type:        DATABASE_OPTIONS_PG17,
 	Name:        "Database options",
 	Impact:      constants.IMPACT_LEVEL_2,
-	Description: "Database options (%s) introduced in PostgreSQL 12 and later are not supported yet in YugabyteDB.",
+	Description: DATABASE_OPTIONS_DESCRIPTION,
 	Suggestion:  "",
 	GH:          "https://github.com/yugabyte/yugabyte-db/issues/25575",
 	DocsLink:    "https://docs.yugabyte.com/preview/yugabyte-voyager/known-issues/postgresql/#postgresql-12-and-later-features",

diff --git a/yb-voyager/src/query/queryparser/helpers_protomsg.go b/yb-voyager/src/query/queryparser/helpers_protomsg.go
@@ -415,14 +415,6 @@ func ProtoAsAConstNode(msg protoreflect.Message) (*pg_query.A_Const, error) {
 	return aConstNode, nil
 }
 
-func ProtoAsCreateDBStmtNode(msg protoreflect.Message) (*pg_query.CreatedbStmt, error) {
-	node, ok := msg.Interface().(*pg_query.CreatedbStmt)
-	if !ok {
-		return nil, fmt.Errorf("failed to cast msg to %s", PG_QUERY_CREATEDB_STMT_NODE)
-	}
-	return node, nil
-}
-
 func ProtoAsCTENode(msg protoreflect.Message) (*pg_query.CommonTableExpr, error) {
 	cteNode, ok := msg.Interface().(*pg_query.CommonTableExpr)
 	if !ok {