Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt credentials #3

Open
IanStorm opened this issue Apr 8, 2020 · 3 comments
Open

Encrypt credentials #3

IanStorm opened this issue Apr 8, 2020 · 3 comments

Comments

@IanStorm
Copy link

IanStorm commented Apr 8, 2020

Hey,
I just included this node in my personal Node-RED flow; it works like a charm. 👍
One thing I saw however: The credentials are stored as plain text in the flows.json file. I think they should be stored inside flows_cred.json, with the advantage of auto-encryption/-decryption done by Node-RED.
So far I don't have experience in creating nodes for Node-RED... I was thinking to give it a try and create a PR to fix that issue. Is this repo still active?
Thanks in advance.

@yuchangyuan
Copy link
Owner

PR is welcome. I am not javascript developer, and currently I do not have enough time to work on this project.

And you can also fork this repo and submit npm, to make you forked node searchable from node-red instance.

@IanStorm
Copy link
Author

IanStorm commented Jun 3, 2020

Thanks for your reply.
I also thought about forking the repo, but definitely prefer to first try to fix it here. (Plus, I didn't want to create another fork of a fork.)
I value your precious time, and I am trying to provide a PR soon.

@yuchangyuan
Copy link
Owner

Beside not have enough time, another reason I not interest in this feature personally is that I use environment variable to refer the password, which injected by kubernetes.

Actually, credential should store in flow_cred.json, and I am looking forward for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants