Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to readme checks #226

Merged
merged 4 commits into from
Feb 28, 2025
Merged

fixes to readme checks #226

merged 4 commits into from
Feb 28, 2025

Conversation

yshavit
Copy link
Owner

@yshavit yshavit commented Feb 28, 2025

  • fix the workflow name
  • fix the job name
  • rm the needs dependency
  • put in the correct version to the readme (I had previously put an intentionally incorrect one, to prove this script works; and then I forgot to remove it)

In service of (and may resolve) #221

@yshavit
Copy link
Owner Author

yshavit commented Feb 28, 2025

I put this on a workflow that only runs on merges to main, not at every push to a PR. It's a relatively slow workflow, and I don't think it'll actually change that frequently, so I'm okay with it detecting changes out of band.

@yshavit yshavit marked this pull request as ready for review February 28, 2025 06:54
@yshavit yshavit mentioned this pull request Feb 28, 2025
2 tasks
@yshavit yshavit merged commit 58fed50 into main Feb 28, 2025
5 checks passed
@yshavit yshavit deleted the workflow-rename branch February 28, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant